Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-Type header not set to application/json #476

Closed
manuelwedler opened this issue Jun 16, 2020 · 3 comments · Fixed by #477
Closed

Content-Type header not set to application/json #476

manuelwedler opened this issue Jun 16, 2020 · 3 comments · Fixed by #477
Labels
bug Something isn't working

Comments

@manuelwedler
Copy link
Contributor

Describe the bug

The Content-Type header of our POST and PUT requests is set to text/plain.
v1.0.0 of Raiden was not complaining of the wrongly set header. The new v1.0.1 client returns {"errors":"JSON payload expected"} in that case. So all POST and PUT requests are failing from the WebUI.

I couldn't find what commit caused this change in the client, but this should get fixed in the WebUI anyway.

Expected behavior

The Content-Type header of our POST and PUT requests should get set to application/json.

System

  • Raiden: v1.0.1
  • WebUI: v1.0.0
  • Environment: development
  • Network: Görli
  • User agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:77.0) Gecko/20100101 Firefox/77.0
@manuelwedler manuelwedler added the bug Something isn't working label Jun 16, 2020
@Dominik1999
Copy link

Thank you for finding this! Why was this bug not found last week during testing? did we change anything?

@manuelwedler
Copy link
Contributor Author

We tested last week on v1.0.0. There must be a change afterwards that leads to this bug.

@palango
Copy link
Contributor

palango commented Jun 17, 2020

It was probably caused by raiden-network/raiden#6246 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants