Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mypy errors around SendSecretReveal #3219

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Remove mypy errors around SendSecretReveal #3219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3a10f6
Remove mypy errors around SendSecretReveal
pirapira Jan 3, 2019
beca9c1
More consistent usage of the typing module
pirapira Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ mypy:
grep Address mypy-out.txt; [ $$? -eq 1 ]
grep ChannelID mypy-out.txt; [ $$? -eq 1 ]
grep BalanceProof mypy-out.txt; [ $$? -eq 1 ]
grep SendSecretReveal mypy-out.txt; [ $$? -eq 1 ]

isort:
isort $(ISORT_PARAMS)
Expand Down
4 changes: 2 additions & 2 deletions raiden/transfer/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,8 @@ def to_dict(self) -> Dict[str, Any]:
@classmethod
def from_dict(cls, data: Dict[str, Any]) -> 'ContractSendSecretReveal':
restored = cls(
expiration=int(data['expiration']),
secret=serialization.deserialize_bytes(data['secret']),
expiration=BlockExpiration(int(data['expiration'])),
secret=Secret(serialization.deserialize_bytes(data['secret'])),
)

return restored
Expand Down
Loading