Remove mypy errors around SendSecretReveal #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirapira
force-pushed
the
SendSecretReveal
branch
2 times, most recently
from
ae2c582
to
6d440f7
Compare
pirapira
commented
Jan 3, 2019
pirapira
force-pushed
the
SendSecretReveal
branch
from
6d440f7
to
bb27bdb
Compare
LefterisJP
reviewed
Jan 4, 2019
|
And why didn't I submit the change in Makefile? |
In particular, this commit removes the "unknown name" error in mediated_transfer/state.py about SendSecretReveal. After this, it becomes possible to remove warnings from raiden/docs compilation.
in the sprit of raiden-network#3220
pirapira
force-pushed
the
SendSecretReveal
branch
from
bb27bdb
to
beca9c1
Compare
|
I added the Makefile change, too. |
|
@LefterisJP @andrevmatos it should be better now. |
|
Ping @andrevmatos |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this commit removes the "unknown name" error in
mediated_transfer/state.pyaboutSendSecretReveal. After this, itbecomes possible to remove warnings from
raiden/docscompilation.