Fix _lookup_to_vector and _lookup_to_interval (#776)

* Fix lookup bug

* Add some tests

* recipes

ext/DimensionalDataMakie.jl

@@ -373,15 +373,15 @@ function Makie.convert_arguments(t::SurfaceLikeCompat, A::AbstractDimMatrix)
 end
 function Makie.convert_arguments(t::Makie.ImageLike, A::AbstractDimMatrix)
     A1 = _prepare_for_makie(A)
-    xs, ys = map(_lookup_to_intervals, lookup(A))
+    xs, ys = map(_lookup_to_interval, lookup(A))
     # the following will not work for irregular spacings, we'll need to add a check for this.
     return xs, ys, last(Makie.convert_arguments(t, parent(A1)))
 end
 function Makie.convert_arguments(
     t::Makie.CellGrid, A::AbstractDimMatrix
 )
     A1 = _prepare_for_makie(A)
-    xs, ys = map(_lookup_to_axis, lookup(A1))
+    xs, ys = map(_lookup_to_vector, lookup(A1))
     return xs, ys, last(Makie.convert_arguments(t, parent(A1)))
 end
 function Makie.convert_arguments(t::Makie.VolumeLike, A::AbstractDimArray{<:Any,3}) 

test/plotrecipes.jl

@@ -244,6 +244,19 @@ end
     A2m[3] = missing
     A2rgb = rand(RGB, X(10:10:100), Y(['a', 'b', 'c']))
 
+    #Test whether the conversion functions work
+    #TODO once surface2 is corrected to use the plottrait this should
+    #already be tested with the usual plotting functions
+    M.convert_arguments(M.CellGrid(), A2)
+    M.convert_arguments(M.VertexGrid(), A2)
+    M.convert_arguments(M.ImageLike(), A2)
+
+    M.convert_arguments(M.CellGrid(), A2u)
+    M.convert_arguments(M.VertexGrid(), A2u)
+    M.convert_arguments(M.ImageLike(), A2u)
+
+
+
     fig, ax, _ = M.plot(A2)
     M.plot!(ax, A2)
     fig, ax, _ = M.plot(A2m)