Fix _lookup_to_vector and _lookup_to_interval #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaqz
pushed a commit
that referenced
this pull request
Sep 1, 2024
* Fix lookup bug * Add some tests * recipes
rafaqz
added a commit
that referenced
this pull request
Sep 1, 2024
* Correct the name and change surface2 to use the correct conversion trait for that plot * Fix test problems * Tried to be more generic with the conversion but getting stackoverflow * Hack together something to see if tests pass * Fix _lookup_to_vector and _lookup_to_interval (#776) * Fix lookup bug * Add some tests * recipes --------- Co-authored-by: Paul Tiede <ptiede91@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the small bugs in convert_arguments for ImageLike and CellGrid.