Re-enable skipped test `Test_RecipeCommands` #7080

sk593 · 2024-01-26T17:46:23Z

Description

This re-enables Test_RecipeCommands

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius Re-enable skipped functional test: Test_RecipeCommands #6776

Fixes: #6776

radius-functional-tests · 2024-01-26T17:50:09Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	sk593/radius
Commit ref	`4eebbce`
Unique ID	4c34da2f15
Image tag	pr-4c34da2f15

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-4c34da2f15
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-4c34da2f15
controller test image location: ghcr.io/radius-project/dev/controller:pr-4c34da2f15
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-4c34da2f15
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
❌ shared functional test failed. Please check the logs for more details

ytimocin · 2024-01-29T19:39:03Z

test/functional/shared/cli/cli_test.go

+	registry := strings.TrimPrefix(functional.GetBicepRecipeRegistry(), "registry=")
+	version := strings.TrimPrefix(functional.GetBicepRecipeVersion(), "version=")


Why do we need to do this?

These functions prefix the registry and version strings so we need to remove them for this test.

radius/test/functional/testUtil.go

Line 91 in c262df7

func GetBicepRecipeRegistry() string {

radius-functional-tests · 2024-01-29T19:40:05Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	sk593/radius
Commit ref	`a7fd160`
Unique ID	aa582cab14
Image tag	pr-aa582cab14

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-aa582cab14
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-aa582cab14
controller test image location: ghcr.io/radius-project/dev/controller:pr-aa582cab14
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-aa582cab14
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

test/functional/shared/cli/cli_test.go

radius-functional-tests · 2024-01-31T18:53:36Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	sk593/radius
Commit ref	`347b898`
Unique ID	2ac44e23e3
Image tag	pr-2ac44e23e3

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-2ac44e23e3
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-2ac44e23e3
controller test image location: ghcr.io/radius-project/dev/controller:pr-2ac44e23e3
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-2ac44e23e3
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ shared functional tests succeeded

radius-functional-tests · 2024-01-31T19:46:04Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	sk593/radius
Commit ref	`55ea162`
Unique ID	a96aa1def6
Image tag	pr-a96aa1def6

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-a96aa1def6
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-a96aa1def6
controller test image location: ghcr.io/radius-project/dev/controller:pr-a96aa1def6
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-a96aa1def6
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

Signed-off-by: sk593 <shruthikumar@microsoft.com>

radius-functional-tests · 2024-01-31T20:34:56Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	sk593/radius
Commit ref	`dd3122f`
Unique ID	496873c468
Image tag	pr-496873c468

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-496873c468
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-496873c468
controller test image location: ghcr.io/radius-project/dev/controller:pr-496873c468
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-496873c468
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ samples functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

radius-functional-tests · 2024-01-31T21:11:49Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	sk593/radius
Commit ref	`22fab48`
Unique ID	a82dab5c27
Image tag	pr-a82dab5c27

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-a82dab5c27
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-a82dab5c27
controller test image location: ghcr.io/radius-project/dev/controller:pr-a82dab5c27
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-a82dab5c27
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

# Description This re-enables `Test_RecipeCommands` ## Type of change  - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius radius-project#6776  Fixes: radius-project#6776 --------- Signed-off-by: sk593 <shruthikumar@microsoft.com> Co-authored-by: Karishma Chawla <kachawla@microsoft.com>

sk593 requested review from a team as code owners January 26, 2024 17:46

sk593 temporarily deployed to functional-tests January 26, 2024 17:49 — with GitHub Actions Inactive

sk593 force-pushed the recipe-commands-test branch from ed2ec85 to b3cd519 Compare January 29, 2024 19:31

ytimocin reviewed Jan 29, 2024

View reviewed changes

sk593 temporarily deployed to functional-tests January 29, 2024 19:39 — with GitHub Actions Inactive

kachawla reviewed Jan 30, 2024

View reviewed changes

test/functional/shared/cli/cli_test.go Outdated Show resolved Hide resolved

test/functional/shared/cli/cli_test.go Outdated Show resolved Hide resolved

test/functional/shared/cli/cli_test.go Outdated Show resolved Hide resolved

sk593 force-pushed the recipe-commands-test branch from 8fb8a15 to 7a82fee Compare January 31, 2024 17:05

kachawla approved these changes Jan 31, 2024

View reviewed changes

sk593 temporarily deployed to functional-tests January 31, 2024 18:52 — with GitHub Actions Inactive

sk593 temporarily deployed to functional-tests January 31, 2024 19:45 — with GitHub Actions Inactive

lakshmimsft approved these changes Jan 31, 2024

View reviewed changes

sk593 added 4 commits January 31, 2024 12:04

reenable skipped recipe test

771d35e

Signed-off-by: sk593 <shruthikumar@microsoft.com>

update func tests

d6f7fb5

Signed-off-by: sk593 <shruthikumar@microsoft.com>

update func tests

9482bdb

Signed-off-by: sk593 <shruthikumar@microsoft.com>

updating recipe functional tests

dd3122f

Signed-off-by: sk593 <shruthikumar@microsoft.com>

sk593 force-pushed the recipe-commands-test branch from 55ea162 to dd3122f Compare January 31, 2024 20:04

sk593 temporarily deployed to functional-tests January 31, 2024 20:34 — with GitHub Actions Inactive

Merge branch 'main' into recipe-commands-test

22fab48

kachawla temporarily deployed to functional-tests January 31, 2024 21:11 — with GitHub Actions Inactive

kachawla merged commit 6108d14 into radius-project:main Jan 31, 2024
16 checks passed

sk593 deleted the recipe-commands-test branch January 31, 2024 21:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-enable skipped test `Test_RecipeCommands` #7080

Re-enable skipped test `Test_RecipeCommands` #7080

sk593 commented Jan 26, 2024

radius-functional-tests bot commented Jan 26, 2024 •

edited

Loading

ytimocin Jan 29, 2024

sk593 Jan 29, 2024

radius-functional-tests bot commented Jan 29, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 31, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 31, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 31, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 31, 2024 •

edited

Loading

		registry := strings.TrimPrefix(functional.GetBicepRecipeRegistry(), "registry=")
		version := strings.TrimPrefix(functional.GetBicepRecipeVersion(), "version=")

Re-enable skipped test Test_RecipeCommands #7080

Re-enable skipped test Test_RecipeCommands #7080

Conversation

sk593 commented Jan 26, 2024

Description

Type of change

radius-functional-tests bot commented Jan 26, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin Jan 29, 2024

Choose a reason for hiding this comment

sk593 Jan 29, 2024

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 29, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 31, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 31, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 31, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 31, 2024 • edited Loading

Radius functional test overview

Test Status

Re-enable skipped test `Test_RecipeCommands` #7080

Re-enable skipped test `Test_RecipeCommands` #7080

radius-functional-tests bot commented Jan 26, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 29, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 31, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 31, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 31, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 31, 2024 •

edited

Loading