Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable skipped functional test: Test_RecipeCommands #6776

Closed
kachawla opened this issue Nov 15, 2023 · 3 comments · Fixed by #7080
Closed

Re-enable skipped functional test: Test_RecipeCommands #6776

kachawla opened this issue Nov 15, 2023 · 3 comments · Fixed by #7080
Labels
important This item is a high priority Issue we intend to address as soon as possible maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. skipped-test Skipped functional/unit tests. triaged This issue has been reviewed and triaged

Comments

@kachawla
Copy link
Contributor

kachawla commented Nov 15, 2023 •
edited
Loading

Just noticed that Test_RecipeCommands functional test was disabled as a part of migration to GHCR effort here: a197131. It's unclear what the plan to re-enable the test is, so creating this issue to ensure we get back to this and have test coverage here.

AB#10306
@kachawla kachawla added the maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. label Nov 15, 2023
@radius-triage-bot
Copy link

👋 @kachawla Thanks for filing this issue.

A project maintainer will review this issue and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@shalabhms shalabhms added important This item is a high priority Issue we intend to address as soon as possible triaged This issue has been reviewed and triaged labels Nov 16, 2023
@radius-triage-bot
Copy link

We've prioritized work on this issue. Please subscribe to this issue for notifications, we'll provide updates as we make progress.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@kachawla kachawla changed the title Re-enable skipped functional test Re-enable skipped functional test: Test_RecipeCommands Dec 13, 2023
@kachawla kachawla changed the title Re-enable skipped functional test: Test_RecipeCommands Re-enable skipped functional test: Test_RecipeCommands Dec 13, 2023
@kachawla kachawla added the skipped-test Skipped functional/unit tests. label Jan 25, 2024
@sk593 sk593 mentioned this issue Jan 26, 2024
Merged
kachawla added a commit that referenced this issue Jan 31, 2024
@sk593 @kachawla
Re-enable skipped test Test_RecipeCommands (#7080)
6108d14 
# Description

This re-enables `Test_RecipeCommands` 

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
#6776

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #6776

---------

Signed-off-by: sk593 <shruthikumar@microsoft.com>
Co-authored-by: Karishma Chawla <kachawla@microsoft.com>
willdavsmith pushed a commit to willdavsmith/radius that referenced this issue Mar 4, 2024
@sk593 @kachawla @willdavsmith
Re-enable skipped test Test_RecipeCommands (radius-project#7080)
39fed13 
# Description

This re-enables `Test_RecipeCommands` 

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
radius-project#6776

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#6776

---------

Signed-off-by: sk593 <shruthikumar@microsoft.com>
Co-authored-by: Karishma Chawla <kachawla@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
important This item is a high priority Issue we intend to address as soon as possible maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. skipped-test Skipped functional/unit tests. triaged This issue has been reviewed and triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable skipped test Test_RecipeCommands sk593/radius
2 participants
@shalabhms @kachawla