fix: remove duplicate securityContext #6996
Conversation
Signed-off-by: Ivan Josipovic <9521987+IvanJosipovic@users.noreply.github.com>
| @@ -73,8 +73,6 @@ spec: | |||
| mountPath: {{ .Values.global.rootCA.mountPath }} | |||
| readOnly: true | |||
| {{- end }} | |||
| securityContext: | |||
| allowPrivilegeEscalation: false | |||
There was a problem hiding this comment.
For anyone else reviewing this, it's a duplicate of Line 64 in the same file: https://github.com/radius-project/radius/pull/6996/files#diff-92bd08c7c2302e12d2ceb2f7bf0a5bdd0016bb8e2eb2639588e994366e9ee841L64
There was a problem hiding this comment.
I checked the other files in the chart, and they all look good: https://github.com/search?q=repo%3Aradius-project%2Fradius%20securityContext&type=code
IvanJosipovic
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
- thanks 
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
Merged, thanks! |
|
Hello. I'm still experiencing the duplicate securityContext error when deploying the Helm chart with Flux.
|
# Description
When installing the 0.29.0 helm chart, I received an error message:
```
Helm install failed for release radius-system/radius with chart radius@0.29.0: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
line 61: mapping key "securityContext" already defined at line 54
```
This PR removed the duplicate key :)
## Type of change
<!--
Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.
If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.
-->
- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
<!--
Please update the following to link the associated issue. This is
required for some kinds of changes (see above).
-->
Issue: radius-project#6997
Signed-off-by: Ivan Josipovic <9521987+IvanJosipovic@users.noreply.github.com>
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Hi @smorenburg! I see in the screenshot attached that you are using 0.29 release chart. From what I see, the changes in this PR are not released yet: v0.29.0...main. Please let me know if I am missing something. With that being said, could you let me know which Flux commands you are running to reproduce this issue? I will try to do a deeper investigation myself and I am not very familiar with Flux (but am willing to be). You can point to the main branch for the most up-to-date charts. Happy to sync offline, if you would also like, to tackle this problem further. |
|
Hi @ytimocin, thanks for the quick response. I could deploy the Helm chart with Flux using the repository's main branch instead of the published chart (https://radius.azurecr.io/helm/v1/repo). @IvanJosipovic's change works! https://github.com/smorenburg/astro-source/blob/main/infrastructure/base/controllers/radius.yaml I hope you have a great day. |
|
That is great @smorenburg! This change will be in our upcoming release. Thanks for the link. I will test it out myself. Have a good day! |
Description
When installing the 0.29.0 helm chart, I received an error message:
This PR removed the duplicate key :)
Type of change
Issue: #6997