Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate securityContext in Helm Chart #6997

Closed
IvanJosipovic opened this issue Jan 6, 2024 · 6 comments
Closed

duplicate securityContext in Helm Chart #6997

IvanJosipovic opened this issue Jan 6, 2024 · 6 comments
Labels
bug Something is broken or not working as expected triaged This issue has been reviewed and triaged

Comments

@IvanJosipovic
Copy link
Contributor

IvanJosipovic commented Jan 6, 2024

Bug information

Steps to reproduce (required)

When installing the Helm Chart version 0.29.0 using Flux, the installation fails.

Duplicate key:

Observed behavior (required)

Flux was not able to install the Helm Chart due to the following error:

Helm install failed for release radius-system/radius with chart radius@0.29.0: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
        line 61: mapping key "securityContext" already defined at line 54
apiVersion: helm.toolkit.fluxcd.io/v2beta2
kind: HelmRelease
metadata:
  creationTimestamp: 2024-01-06T00:59:32.0000000Z
  finalizers:
  - finalizers.fluxcd.io
  generation: 1
  labels:
    kustomize.toolkit.fluxcd.io/name: app
    kustomize.toolkit.fluxcd.io/namespace: flux-system
  name: radius
  namespace: radius-system
  resourceVersion: "346228560"
  uid: 9928587c-861c-424c-9f4a-ec0681b574b1
spec:
  chart:
    spec:
      chart: radius
      interval: 10m
      reconcileStrategy: ChartVersion
      sourceRef:
        kind: HelmRepository
        name: repo
        namespace: radius-system
      version: 0.29.0
  interval: 5m
  releaseName: radius
status:
  conditions:
  - lastTransitionTime: 2024-01-06T01:19:01Z
    message: Running 'install' action with timeout of 5m0s
    observedGeneration: 1
    reason: Progressing
    status: "True"
    type: Reconciling
  - lastTransitionTime: 2024-01-06T01:19:05Z
    message: |-
      Helm install failed for release radius-system/radius with chart radius@0.29.0: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
        line 61: mapping key "securityContext" already defined at line 54
    observedGeneration: 1
    reason: InstallFailed
    status: "False"
    type: Ready
  - lastTransitionTime: 2024-01-06T01:05:35Z
    message: |-
      Helm install failed for release radius-system/radius with chart radius@0.29.0: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
        line 61: mapping key "securityContext" already defined at line 54
    observedGeneration: 1
    reason: InstallFailed
    status: "False"
    type: Released
  failures: 11
  helmChart: radius-system/radius-system-radius
  lastAttemptedConfigDigest: sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
  lastAttemptedGeneration: 1
  lastAttemptedReleaseAction: install
  lastAttemptedRevision: 0.29.0
  observedGeneration: -1
  storageNamespace: radius-system

Desired behavior (required)

Helm install should succeed

Workaround (optional)

Deploy the chart using the Helm CLI

System information

rad Version (required)

0.29.0

Operating system (required)

Windows 11, amd64

Additional context

AB#10827

@IvanJosipovic IvanJosipovic added the bug Something is broken or not working as expected label Jan 6, 2024
@radius-triage-bot
Copy link

👋 @IvanJosipovic Thanks for filing this bug report.

A project maintainer will review this report and get back to you soon. If you'd like immediate help troubleshooting, please visit our Discord server.

For more information on our triage process please visit our triage overview

@rynowak
Copy link
Contributor

rynowak commented Jan 6, 2024

@shalabhms @sylvainsf @AaronCrawfis @willtsai - this is probably worth a patch release since it's blocking install. Thoughts?

@IvanJosipovic
Copy link
Contributor Author

@shalabhms @sylvainsf @AaronCrawfis @willtsai - this is probably worth a patch release since it's blocking install. Thoughts?

Please note, this is only blocking installs through Flux, as it appears to do additional validation.

Installing through the Helm CLI worked as expected

helm install radius radius/radius -n radius-system

rynowak pushed a commit that referenced this issue Jan 6, 2024
# Description

When installing the 0.29.0 helm chart, I received an error message:

```
Helm install failed for release radius-system/radius with chart radius@0.29.0: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
        line 61: mapping key "securityContext" already defined at line 54
```

This PR removed the duplicate key :)

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Issue: #6997

Signed-off-by: Ivan Josipovic <9521987+IvanJosipovic@users.noreply.github.com>
@rynowak
Copy link
Contributor

rynowak commented Jan 6, 2024

The fix for this has been merged into main. Leaving the issue open until we decide whether to patch or not.

@shalabhms
Copy link
Contributor

shalabhms commented Jan 8, 2024

triage: decided not to issue the patch as it is blocking install through Flux only and not through Helm.
Closing the issue as this is fixed as part of #6996

@shalabhms shalabhms added the triaged This issue has been reviewed and triaged label Jan 8, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

willdavsmith pushed a commit to willdavsmith/radius that referenced this issue Jan 17, 2024
# Description

When installing the 0.29.0 helm chart, I received an error message:

```
Helm install failed for release radius-system/radius with chart radius@0.29.0: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
        line 61: mapping key "securityContext" already defined at line 54
```

This PR removed the duplicate key :)

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Issue: radius-project#6997

Signed-off-by: Ivan Josipovic <9521987+IvanJosipovic@users.noreply.github.com>
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken or not working as expected triaged This issue has been reviewed and triaged
Projects
None yet
Development

No branches or pull requests

3 participants