Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for sql auth in Radius tests #7851

Closed
1 task
nicolejms opened this issue Aug 27, 2024 · 2 comments · Fixed by #7974
Closed
1 task

Remove need for sql auth in Radius tests #7851

nicolejms opened this issue Aug 27, 2024 · 2 comments · Fixed by #7974
Assignees
Labels
maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. triaged This issue has been reviewed and triaged

Comments

@nicolejms
Copy link
Contributor

nicolejms commented Aug 27, 2024

Area for Improvement

There should be no long lived sql server created with sql auth enabled for testing

Observed behavior

No response

Desired behavior

Either sql server is created on the fly and dropped after tests complete
or
Federated identity is used to connect to sql derver

Proposed Fix

No response

rad Version

v0.37

Operating system

No response

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#13090

@nicolejms nicolejms added the maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. label Aug 27, 2024
@radius-triage-bot
Copy link

👋 @nicolejms Thanks for filing this issue.

A project maintainer will review this issue and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@ytimocin ytimocin added the triaged This issue has been reviewed and triaged label Aug 29, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

kachawla pushed a commit that referenced this issue Oct 16, 2024
# Description

Cleaning up some resource IDs in the sql processor test and deleting the
cloud sql DB functional test since this use case is already covered in a
locally-hosted scenario here:
https://github.com/radius-project/radius/blob/38fcc3e5b705df25d77bee4242948d1ec49013d3/test/functional-portable/datastoresrp/noncloud/resources/sql_test.go#L29

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #7851

Signed-off-by: sk593 <shruthikumar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. triaged This issue has been reviewed and triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants