-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup SQL databases tests #7974
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7974 +/- ##
==========================================
- Coverage 60.36% 60.36% -0.01%
==========================================
Files 560 560
Lines 29417 29417
==========================================
- Hits 17759 17757 -2
- Misses 10112 10113 +1
- Partials 1546 1547 +1 ☔ View full report in Codecov by Sentry. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
@@ -20,7 +20,7 @@ import ( | |||
func Test_Process(t *testing.T) { | |||
processor := Processor{} | |||
|
|||
const azureSqlResourceID = "/subscriptions/85716382-7362-45c3-ae03-2126e459a123/resourceGroups/RadiusFunctionalTest/providers/Microsoft.Sql/servers/mssql-radiustest/databases/database-radiustest" | |||
const azureSqlResourceID = "/subscriptions/0000/resourceGroups/test-group/providers/Microsoft.Sql/servers/sql.server/databases/database-radiustest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the subscription id be in form of UUID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In practice it will be. For testing purposes, it doesn't really matter and the other processor tests follow this format
@@ -20,7 +20,7 @@ import ( | |||
func Test_Process(t *testing.T) { | |||
processor := Processor{} | |||
|
|||
const azureSqlResourceID = "/subscriptions/85716382-7362-45c3-ae03-2126e459a123/resourceGroups/RadiusFunctionalTest/providers/Microsoft.Sql/servers/mssql-radiustest/databases/database-radiustest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
b9d927a
to
ccbad90
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
8fc1be6
to
8637bbb
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
aa71273
to
79e834e
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: sk593 <shruthikumar@microsoft.com>
929b798
to
7520828
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
test.RequiredFeatures = []rp.RequiredFeature{rp.FeatureAzure} | ||
test.Test(t) | ||
} | ||
// TODO: This test will be deleted in a followup PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping this test for now so that the functional tests pass. This will be deleted in a followup PR with additional updates to the datastoresrp-cloud
make targets
Description
Cleaning up some resource IDs in the sql processor test and deleting the cloud sql DB functional test since this use case is already covered in a locally-hosted scenario here:
radius/test/functional-portable/datastoresrp/noncloud/resources/sql_test.go
Line 29 in 38fcc3e
Type of change
Fixes: #7851