Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup SQL databases tests #7974

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Oct 1, 2024

Description

Cleaning up some resource IDs in the sql processor test and deleting the cloud sql DB functional test since this use case is already covered in a locally-hosted scenario here:

func Test_SQLDatabase_Manual(t *testing.T) {

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #7851

@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 1, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref 08f8700
Unique ID func1781a7728d
Image tag pr-func1781a7728d
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1781a7728d
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1781a7728d
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func1781a7728d
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1781a7728d
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded
❌ datastoresrp-cloud functional test failed. Please check the logs for more details

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.36%. Comparing base (7918871) to head (7520828).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7974      +/-   ##
==========================================
- Coverage   60.36%   60.36%   -0.01%     
==========================================
  Files         560      560              
  Lines       29417    29417              
==========================================
- Hits        17759    17757       -2     
- Misses      10112    10113       +1     
- Partials     1546     1547       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 2, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref 9912cf1
Unique ID funcb2b028de9c
Image tag pr-funcb2b028de9c
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcb2b028de9c
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcb2b028de9c
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcb2b028de9c
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcb2b028de9c
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded
❌ datastoresrp-cloud functional test failed. Please check the logs for more details

@@ -20,7 +20,7 @@ import (
func Test_Process(t *testing.T) {
processor := Processor{}

const azureSqlResourceID = "/subscriptions/85716382-7362-45c3-ae03-2126e459a123/resourceGroups/RadiusFunctionalTest/providers/Microsoft.Sql/servers/mssql-radiustest/databases/database-radiustest"
const azureSqlResourceID = "/subscriptions/0000/resourceGroups/test-group/providers/Microsoft.Sql/servers/sql.server/databases/database-radiustest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the subscription id be in form of UUID?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice it will be. For testing purposes, it doesn't really matter and the other processor tests follow this format

@@ -20,7 +20,7 @@ import (
func Test_Process(t *testing.T) {
processor := Processor{}

const azureSqlResourceID = "/subscriptions/85716382-7362-45c3-ae03-2126e459a123/resourceGroups/RadiusFunctionalTest/providers/Microsoft.Sql/servers/mssql-radiustest/databases/database-radiustest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 14, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref 59a15fd
Unique ID func137c979fe3
Image tag pr-func137c979fe3
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func137c979fe3
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func137c979fe3
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func137c979fe3
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func137c979fe3
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
❌ Container images build failed
❌ Test recipe publishing failed

@sk593 sk593 changed the title [wip] Cleanup SQL databases tests Cleanup SQL databases tests Oct 15, 2024
@sk593 sk593 marked this pull request as ready for review October 15, 2024 20:26
@sk593 sk593 requested review from a team as code owners October 15, 2024 20:26
@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 15, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref 6c07111
Unique ID func563e7ebca2
Image tag pr-func563e7ebca2
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func563e7ebca2
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func563e7ebca2
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func563e7ebca2
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func563e7ebca2
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
❌ datastoresrp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

lakshmimsft
lakshmimsft previously approved these changes Oct 15, 2024
kachawla
kachawla previously approved these changes Oct 15, 2024
@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 15, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref b9d927a
Unique ID func5ff9e8ccd4
Image tag pr-func5ff9e8ccd4
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func5ff9e8ccd4
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func5ff9e8ccd4
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func5ff9e8ccd4
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func5ff9e8ccd4
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ datastoresrp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 15, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref 8fc1be6
Unique ID funcf70db03109
Image tag pr-funcf70db03109
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcf70db03109
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcf70db03109
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcf70db03109
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcf70db03109
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ datastoresrp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 16, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref aa71273
Unique ID funcce8f1e424e
Image tag pr-funcce8f1e424e
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcce8f1e424e
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcce8f1e424e
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcce8f1e424e
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcce8f1e424e
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ datastoresrp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 16, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref 79e834e
Unique ID func530ef6794b
Image tag pr-func530ef6794b
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func530ef6794b
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func530ef6794b
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func530ef6794b
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func530ef6794b
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ datastoresrp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 16, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref 929b798
Unique ID func9264e0f599
Image tag pr-func9264e0f599
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func9264e0f599
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func9264e0f599
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func9264e0f599
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func9264e0f599
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
❌ datastoresrp-cloud functional test failed. Please check the logs for more details

Signed-off-by: sk593 <shruthikumar@microsoft.com>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 16, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref 7520828
Unique ID funce661363d1b
Image tag pr-funce661363d1b
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funce661363d1b
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funce661363d1b
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funce661363d1b
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funce661363d1b
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded

test.RequiredFeatures = []rp.RequiredFeature{rp.FeatureAzure}
test.Test(t)
}
// TODO: This test will be deleted in a followup PR
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this test for now so that the functional tests pass. This will be deleted in a followup PR with additional updates to the datastoresrp-cloud make targets

@kachawla kachawla merged commit 0e38ebc into radius-project:main Oct 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove need for sql auth in Radius tests
5 participants