-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move from 3.6 to 3.7 #2909
move from 3.6 to 3.7 #2909
Changes from 1 commit
7916991
5d1608a
329f4bf
cb6468c
07db0b2
e82b69e
809e4fb
780c049
66eb3cf
23c5b7f
bb0e8aa
6cad2ed
f85762a
daa25e6
402674c
59c7601
fafddd9
643221e
648f772
33d2f49
7183020
cc88659
ef462d8
4a9620d
433384b
ee7dafc
dbcb4ef
73e188e
802643d
a7a474b
7f33d04
4ac6b2a
f1b0e26
2bff242
3f5b51d
3d1be81
ab343b1
c79b083
358b77b
7015ca4
b2a6dcb
d3c5b1c
adf7ede
684e450
1c31428
fdcc901
1968ad9
6ac091a
7410042
917ec46
0b5fb47
e2fb6b9
3354e16
c3ed14e
c18682c
e05efb5
7a639d2
56eca36
b720cd9
cab38f8
65b151d
71e7021
dd3ddd6
48d0dad
ac062e8
29ac64a
0d40cf3
61a2112
3634a52
1e272db
52acd00
06ea8eb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,7 @@ jobs: | |
python-version: [ '3.7', '3.8', '3.9', '3.10', '3.11' ] | ||
include: | ||
- os: ubuntu-20.04 | ||
python-version: '3.6' | ||
python-version: '3.7' | ||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
|
@@ -97,7 +97,7 @@ jobs: | |
python-version: [ '3.7', '3.8', '3.9', '3.10', '3.11' ] | ||
include: | ||
- os: ubuntu-20.04 | ||
python-version: '3.6' | ||
python-version: '3.7' | ||
Comment on lines
92
to
+94
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above, all three lines to be removed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will do There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mtitov : Sorry, I lost the context of this comment - what lines should be removed? |
||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -167,9 +167,9 @@ def get_version(_mod_root): | |
|
||
|
||
# ------------------------------------------------------------------------------ | ||
# check python version, should be >= 3.6 | ||
# check python version, should be >= 3.7 | ||
if sys.hexversion < 0x03060000: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, I knew we had this somewhere - overlooked... Thanks! |
||
raise RuntimeError('ERROR: %s requires Python 3.6 or newer' % name) | ||
raise RuntimeError('ERROR: %s requires Python 3.7 or newer' % name) | ||
|
||
|
||
# ------------------------------------------------------------------------------ | ||
|
@@ -224,15 +224,15 @@ def run(self): | |
}, | ||
'license' : 'MIT', | ||
'keywords' : 'radical pilot job saga', | ||
'python_requires' : '>=3.6', | ||
'python_requires' : '>=3.7', | ||
'classifiers' : [ | ||
'Development Status :: 5 - Production/Stable', | ||
'Intended Audience :: Developers', | ||
'Environment :: Console', | ||
'License :: OSI Approved :: MIT License', | ||
'Programming Language :: Python', | ||
'Programming Language :: Python :: 3', | ||
'Programming Language :: Python :: 3.6', | ||
'Programming Language :: Python :: 3.7', | ||
'Topic :: Utilities', | ||
'Topic :: System :: Distributed Computing', | ||
'Topic :: Scientific/Engineering', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these 3 lines could be removed then (3.7 is in matrix already)