move from 3.6 to 3.7 #2909
move from 3.6 to 3.7 #2909
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2909 +/- ##
==========================================
- Coverage 44.54% 41.85% -2.70%
==========================================
Files 96 95 -1
Lines 10555 10535 -20
==========================================
- Hits 4702 4409 -293
- Misses 5853 6126 +273 ☔ View full report in Codecov by Sentry. |
.github/workflows/ci.yml
Outdated
| include: | ||
| - os: ubuntu-20.04 | ||
| python-version: '3.6' | ||
| python-version: '3.7' |
There was a problem hiding this comment.
these 3 lines could be removed then (3.7 is in matrix already)
| include: | ||
| - os: ubuntu-20.04 | ||
| python-version: '3.6' | ||
| python-version: '3.7' |
There was a problem hiding this comment.
same as above, all three lines to be removed
There was a problem hiding this comment.
@mtitov : Sorry, I lost the context of this comment - what lines should be removed?
setup.py
Outdated
| @@ -167,9 +167,9 @@ def get_version(_mod_root): | |||
|
|
|||
|
|
|||
| # ------------------------------------------------------------------------------ | |||
| # check python version, should be >= 3.6 | |||
| # check python version, should be >= 3.7 | |||
| if sys.hexversion < 0x03060000: | |||
There was a problem hiding this comment.
if sys.hexversion < 0x03070000:
There was a problem hiding this comment.
Ah, I knew we had this somewhere - overlooked... Thanks!
Yeah, I don't mind pushing that down the road a bit. |
|
Note that you will also need to update the |
|
@andre-merzky we can close this PR considering that it is part of other one, which we push right now, and I'll add comments there in regards of this topic. |
Agree - thanks! |
No description provided.