Skip to content

Superstream: Create/Delete superstream and Partition and route commands #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

DanielePalaia
Copy link
Contributor

@DanielePalaia DanielePalaia commented Oct 9, 2024

This closes #9
This closes #8

This PR is a first step for super_stream implementation.

It implements:

  • CREATE/DELETE super_stream commands
  • PARTITIONS AND ROUTE commands

Integrate the commands in the Client

@DanielePalaia DanielePalaia marked this pull request as draft October 9, 2024 07:43
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 91.62562% with 34 lines in your changes missing coverage. Please review.

Project coverage is 89.12%. Comparing base (04e184b) to head (4a7cb45).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
protocol/src/commands/superstream_partitions.rs 85.52% 11 Missing ⚠️
protocol/src/commands/superstream_route.rs 86.41% 11 Missing ⚠️
src/stream_creator.rs 78.78% 7 Missing ⚠️
src/environment.rs 63.63% 4 Missing ⚠️
src/client/mod.rs 97.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   88.90%   89.12%   +0.21%     
==========================================
  Files          71       75       +4     
  Lines        6065     6407     +342     
==========================================
+ Hits         5392     5710     +318     
- Misses        673      697      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielePalaia DanielePalaia marked this pull request as ready for review October 9, 2024 07:47
@DanielePalaia DanielePalaia changed the title DRAFT: Partition and route commands Partition and route commands Oct 9, 2024
@DanielePalaia DanielePalaia changed the title Partition and route commands Superstream: Create/Delete superstream and Partition and route commands Oct 9, 2024
Copy link
Collaborator

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@DanielePalaia DanielePalaia merged commit d705bfb into main Oct 17, 2024
4 checks passed
@DanielePalaia DanielePalaia deleted the partition_and_route_commands branch October 17, 2024 11:39
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route [command] Partitions [command]
2 participants