Skip to content

Implementing create and delete superstream commands #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

DanielePalaia
Copy link
Contributor

First phase of super_stream implementation: Implemented create and delete superstream commands

@DanielePalaia DanielePalaia marked this pull request as draft October 4, 2024 12:02
@DanielePalaia DanielePalaia force-pushed the implement_super_stream_creation_deletion branch from 4ff24ba to 309973a Compare October 4, 2024 13:17
@DanielePalaia DanielePalaia force-pushed the implement_super_stream_creation_deletion branch from 309973a to 9a89e3e Compare October 4, 2024 13:32
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 89.04%. Comparing base (04e184b) to head (551df26).

Files with missing lines Patch % Lines
src/stream_creator.rs 78.78% 7 Missing ⚠️
src/environment.rs 63.63% 4 Missing ⚠️
src/client/mod.rs 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   88.90%   89.04%   +0.14%     
==========================================
  Files          71       73       +2     
  Lines        6065     6181     +116     
==========================================
+ Hits         5392     5504     +112     
- Misses        673      677       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielePalaia DanielePalaia changed the title WIP: implementing create and delete superstream commands Implementing create and delete superstream commands Oct 8, 2024
@DanielePalaia DanielePalaia marked this pull request as ready for review October 8, 2024 07:23
@DanielePalaia
Copy link
Contributor Author

Hey @wolf4ood @Gsantomaggio what do you think? This is the first step of the superstream implementation. If fine I will continue with the Partitions and Routes commands

@DanielePalaia
Copy link
Contributor Author

@wolf4ood @Gsantomaggio We can also close this one and review directly #230 containing also ROUTE and PARTITIONS commands with some refactoring on tests

@DanielePalaia
Copy link
Contributor Author

Superseded by #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant