Build OCI image for each supported Erlang major version #3143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command `make push` pushes an image tagged VERSION where VERSION in our oci.yaml corresponds to the Git commit SHA. `make push IMAGE_TAG=<additional tag>` pushes two images: 1. tag VERSION 2. tag <additional tag> (branch name in oci.yaml) Before this commit, the same image got pushed 3 times as seen in https://github.com/rabbitmq/rabbitmq-server/pull/3137/checks?check_run_id=2885095969: docker push ***/rabbitmq:46f6d81ad06a9b0b34a791a7fd078c45d66e1196 docker push ***/rabbitmq:46f6d81ad06a9b0b34a791a7fd078c45d66e1196 docker push ***/rabbitmq:46f6d81ad06a9b0b34a791a7fd078c45d66e1196 docker push ***/rabbitmq:faster-binding-recovery After this commit we expect the follwing pushes: docker push ***/rabbitmq:46f6d81ad06a9b0b34a791a7fd078c45d66e1196 docker push ***/rabbitmq:faster-binding-recovery
1. with minimum required Erlang 2. with maximum supported Erlang
|
Hm maybe instead of min/max we could have max, max-1 and max-2. We currently support only 23 and 24 but I think that is unusual and we typically support up to 3 major versions? |
as suggested by @lhoguin. Right now (June 2021), we support only Erlang 23 and 24. In future, we might support 3 Erlang major versions.
This is useful when iterating on and testing the oci.yaml.
|
Good idea @lhoguin. I pushed a commit implementing that. |
ansd
changed the title
|
We support two series and when we can, three for a 3 month long transition period. Still, N and N-1 is a good naming pattern to follow 👍 |
|
Can someone backport to |
ansd
added a commit
to rabbitmq/cluster-operator
that referenced
this pull request
Jun 25, 2021
rabbitmq/rabbitmq-server#3143 enables us to run system tests against latest rabbitmq-server master ensuring we're compatible with our Erlang supported versions as documented in https://www.rabbitmq.com/which-erlang.html
ansd
pushed a commit
that referenced
this pull request
Jun 25, 2021
Build OCI image for each supported Erlang major version (cherry picked from commit f46a267)
ansd
pushed a commit
that referenced
this pull request
Jun 25, 2021
Build OCI image for each supported Erlang major version (cherry picked from commit f46a267)
|
Backported to |
gerhard
added a commit
that referenced
this pull request
Jun 28, 2021
It includes the Erlang/OTP version since #3143 Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
gerhard
added a commit
that referenced
this pull request
Jun 29, 2021
It includes the Erlang/OTP version since #3143 Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @gerhard in #2777 (comment), auto-build OCI images for both Erlang 23 and 24.
Therefore, this job will create two images
Each image will have two tags
For example, for Git commit SHA
1111aaaand branch namemain, the following two docker images and four tags will be pushed to DockerHub:1111aaa-otp-min(image 1)main-otp-min(image 1)1111aaa-otp-max(image 2)main-otp-max(image 2)(While we could have used tag
main-otp-24.0.2instead ofmain-otp-max, I prefer the latter option since we can use that stable tag when specifying the RabbitMQ image in pipelines or LREs.)Needs to be backported to
v3.9.xandv3.8.x.