Add OTP version to the startup banner #2777
Conversation
michaelklishin
changed the title
|
WDYT @mkuratczyk about this proposal? Starting RabbitMQ 3.8.10+8.g5247909.25+stream on Erlang 23.2.3
Copyright (c) 2007-2021 VMware, Inc. or its affiliates.
Licensed under the MPL 2.0. Website: https://rabbitmq.com
## ## RabbitMQ 3.8.10+8.g5247909.25+stream
## ##
########## Copyright (c) 2007-2021 VMware, Inc. or its affiliates.
###### ##
########## Licensed under the MPL 2.0. Website: https://rabbitmq.com
+ Erlang 23.2.3
+ Ubuntu 20.04.1 x86_64
+ OpenSSL 1.1.1f
Doc guides: https://rabbitmq.com/documentation.html
Support: https://rabbitmq.com/contact.html
Tutorials: https://rabbitmq.com/getstarted.html
Monitoring: https://rabbitmq.com/monitoring.html |
mkuratczyk
force-pushed
the
banner-with-otp-version
branch
from
3825042 to
223ad24
Compare
|
I can't find a way to retrieve the operating system details but I implemented the other two lines, additionally with info whether JIT is used: OpenSSL details look a bit funny perhaps but I just print them verbatim as returned by |
|
That looks good to me! I really like the BOOT FAILED
===========
Exception during startup:
error:badarg
erlang:system_info/1
args: [emu_flavor]
rabbit:print_banner/0, line 1192
rabbit:start/2, line 880
application_master:start_it_old/4, line 277The above error reminded me that we should auto-build an OCI for 23 as well as 24, because we didn't see this in 23. cc @ansd If we decide to keep the WDYT @dumbbell, assuming that you also think it would be a good idea to do this, how can we retrieve the OS name, version & platform? |
|
By the way, you may want to rebase this onto |
mkuratczyk
changed the title
|
It should work on Erlang 23 now and the flavor (jit/emu) has been added to the log line. Test failures are unrelated. Give it a try and if it works - let's just do it. This PR has been open for too long given its scope. ;) |
This is purely for information purposes. We have often seen users copy-paste console output when reporting issues, and they miss the most important information: Erlang & SSL library versions. After this change, we are less likely to have ask about the Erlang & SSL library versions via follow-up questions. emu_flavor was introduced in Erlang 24. Erlang 23 has not JIT so we can always return "emu". FWIW, we discourage putting new code in rabbitmq_common as this is meant to be shared between the broker and the client. Also, keeping the function definitions close to where they are called is a good general practice. We discussed the benefits of having the OS line with @dumbbell & @gerhard and concluded that it's not worth the effort. Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
gerhard
force-pushed
the
banner-with-otp-version
branch
from
9192027 to
52bd0d0
Compare
|
You are right @mkuratczyk While we could have continued with the PR 🏓 and made suggestions, we took the quick route. After tests pass, this is good to merge. Thanks for sticking with this!
|
cc @dumbbell @mkuratczyk Part of #2777 Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
cc @dumbbell @mkuratczyk Part of #2777 Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk> (cherry picked from commit 2853ec9)
My bad backport of #2777 - all good now 🙌 Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
Print Erlang/OTP version after the RabbitMQ version in the startup banner. This is purely for information purposes - often users will copy-paste console output when reporting issues. This way we don't have ask about the Erlang version.