Add a partial Bazel build #2938

HoloRin · 2021-03-29T08:24:53Z

Proposed Changes

Add the necessary files needed to build and run most of the deps/rabbit suites with Bazel. The intention to bring all remaining suites online incrementally post merge, but at this point the feedback through the bazel build is believed to be superior to that of the current GitHub Actions workflows (mainly as a consequence of speed).

The updated GitHub Actions workflow is leveraging BuildBuddy for remote execution.

Care has been taken to maintain all of the existing gnu make based build. Any breakage from this merge is accidental.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

Bug fix (non-breaking change which fixes issue #NNNN)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause an observable behavior change in existing systems)
Documentation improvements (corrections, new content, etc)
Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

I have read the CONTRIBUTING.md document
I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
All tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)
Any dependent changes have been merged and published in related repositories

Further Comments

See BAZEL.md for further information about building this way.

via bazel

Ideally we would build erlang with bazel itself, but since we change our erlang version infrequently, this allows us to get started

It seems that the linux sandboxing for bazel is stronger

https://github.com/marketplace/actions/bazel-action

to work around a broken cache

So that we can share the cache accross versions

since BuildBuddy already covers this functionality

for 'bazel run :broker' and 'make run-broker'

the rabbitmq_sbin rule had little to no meaning on its own

to better respect the weaker sandbox strategies on macOS

it does not actually require the standard rabbitmq erlc opts

which appears to be tigher in linux

in a way that won't cause bazel cache collisions

These will be skipped, which will report a failing build if not excluded.

Now that the docker image used for remote execution contains openssl/slapd, these can be run

Add Bazel build files corresponding to rabbitmq/rabbitmq-server#2938 The gnu make build should remain unchanged by theses additions

Adds WORKSPACE.bazel, BUILD.bazel & *.bzl files for partial build & test with Bazel. Introduces a build-time dependency on https://github.com/rabbitmq/bazel-erlang

Add Bazel build files corresponding to rabbitmq/rabbitmq-server#2938 The gnu make build should remain unchanged by theses additions

Adds WORKSPACE.bazel, BUILD.bazel & *.bzl files for partial build & test with Bazel. Introduces a build-time dependency on https://github.com/rabbitmq/bazel-erlang

Add a partial Bazel build (#2938) Adds WORKSPACE.bazel, BUILD.bazel & *.bzl files for partial build & test with Bazel. Introduces a build-time dependency on https://github.com/rabbitmq/bazel-erlang

Adds WORKSPACE.bazel, BUILD.bazel & *.bzl files for partial build & test with Bazel. Introduces a build-time dependency on https://github.com/rabbitmq/bazel-erlang

Add Bazel build files corresponding to #2938 The gnu make build should remain unchanged by theses additions

HoloRin added 30 commits March 26, 2021 14:39

Enough bazel to let the rabbit_common test suite pass

4676d32

Add size attribute to rabbit_common tests

e772ba6

Update the method of running all tests

ecc8f8a

WIP: bazel amqp_client tests

26a32cd

Use bazel python instead of whatever is available on the host

5ed396e

Attempt to run the rabbit_common tests in github actions

a5ebe02

via bazel

More verbose output when running tests

821f898

Make the location of the system erlang installation configurable

70eb747

Ideally we would build erlang with bazel itself, but since we change our erlang version infrequently, this allows us to get started

Add more output to debug github actions + bazel

5864f07

find instead of tree

e9c0288

Set HOME explicitly when running erlc

37f01a6

It seems that the linux sandboxing for bazel is stronger

Remove extra verbose output

1c35187

Update the version of the actions/cache to v2

6a1e02c

Match the bazel invocation from its initial source

a824666

https://github.com/marketplace/actions/bazel-action

Less verbose output from bazel

31b4abc

Change the actions cache key

14ad637

to work around a broken cache

Compile rabbitmqctl

1e24da2

Make it possible to 'bazel run :broker'

755cc93

Fixes for GitHub Actions env

c196d6f

Inject .bazelrc for buildbuddy.io integration

957e01e

Also inject the erlang version into the build

bca7bf5

So that we can share the cache accross versions

Remove GitHub Actions Cache and test log capture

51f19c5

since BuildBuddy already covers this functionality

Split the required and optional plugins in rabbitmq_node rules

1849c5d

Use the same node tempdir in bazel as in make

b6f9117

for 'bazel run :broker' and 'make run-broker'

Fold rabbitmq_sbin rule into rabbitmq_node

a850a49

the rabbitmq_sbin rule had little to no meaning on its own

Allow rabbitmq_cli tests to pass

b063c51

Rework elixir rules in rabbitmq_cli

9df4689

to better respect the weaker sandbox strategies on macOS

rabbitmq_management compilation fix

fc3bf5c

it does not actually require the standard rabbitmq erlc opts

Use fewer symbolic links in an attempt to appease sandboxing

074b8db

which appears to be tigher in linux

Ensure that erlang compilation depends on the erlang version

5fd51cf

in a way that won't cause bazel cache collisions

HoloRin added 13 commits March 26, 2021 14:39

Fix remote compilation

ee8fc13

Mark //deps/amqp10_client:system_SUITE exclusive for now

a5deef4

buildifier

40da594

Add deps/amqp10_common tests to bazel

55e17f6

Add rabbitmq_amqp1_0 tests to bazel

e2efdca

Add rabbitmq_auth_backend_cache to bazel

dbf2707

Add rabbitmq_auth_backend_http to bazel

c78e3d1

Add rabbitmq_auth_backend_ldap to bazel

3427614

Turn of "exclusive" tagged tests in CI

0dab3b0

These will be skipped, which will report a failing build if not excluded.

Use the same docker image as the concourse pipelines

8a7c5a7

Allow the rabbitmq_auth_backend_ldap tests to run

e857ff9

Now that the docker image used for remote execution contains openssl/slapd, these can be run

Restore amqp_client system_SUITE behavior under gnu make

f9e21d8

Restore the original format for workflow_sources

ff81387

HoloRin marked this pull request as ready for review March 29, 2021 08:59

HoloRin merged commit 388654c into master Mar 29, 2021

HoloRin deleted the bazel-rbe branch March 29, 2021 09:02

HoloRin mentioned this pull request Mar 29, 2021

Add Bazel build rabbitmq/rabbitmq-ct-helpers#47

Merged

HoloRin added a commit to rabbitmq/rabbitmq-ct-helpers that referenced this pull request Mar 29, 2021

Add Bazel build (#47)

300d9a3

Add Bazel build files corresponding to rabbitmq/rabbitmq-server#2938 The gnu make build should remain unchanged by theses additions

HoloRin mentioned this pull request Mar 29, 2021

Add Bazel Build rabbitmq/rabbitmq-ct-client-helpers#4

Merged

HoloRin added a commit to rabbitmq/rabbitmq-ct-client-helpers that referenced this pull request Mar 29, 2021

Add Bazel Build (#4)

8d9e96d

Add Bazel build files corresponding to rabbitmq/rabbitmq-server#2938 The gnu make build should remain unchanged by theses additions

HoloRin added a commit that referenced this pull request Mar 29, 2021

Add a partial Bazel build (#2938)

0db8e3e

Adds WORKSPACE.bazel, BUILD.bazel & *.bzl files for partial build & test with Bazel. Introduces a build-time dependency on https://github.com/rabbitmq/bazel-erlang

HoloRin added a commit that referenced this pull request Apr 7, 2021

Add a partial Bazel build (#2938)

8626a79

Adds WORKSPACE.bazel, BUILD.bazel & *.bzl files for partial build & test with Bazel. Introduces a build-time dependency on https://github.com/rabbitmq/bazel-erlang

HoloRin added a commit that referenced this pull request Apr 7, 2021

Add a partial Bazel build (#2938)

ef9b0e5

Adds WORKSPACE.bazel, BUILD.bazel & *.bzl files for partial build & test with Bazel. Introduces a build-time dependency on https://github.com/rabbitmq/bazel-erlang

HoloRin added a commit to rabbitmq/rabbitmq-ct-helpers that referenced this pull request Apr 7, 2021

Add Bazel build (#47)

4052c70

Add Bazel build files corresponding to rabbitmq/rabbitmq-server#2938 The gnu make build should remain unchanged by theses additions

HoloRin added a commit to rabbitmq/rabbitmq-ct-client-helpers that referenced this pull request Apr 7, 2021

Add Bazel Build (#4)

57afebd

Add Bazel build files corresponding to rabbitmq/rabbitmq-server#2938 The gnu make build should remain unchanged by theses additions

HoloRin added a commit that referenced this pull request Apr 7, 2021

Add a partial Bazel build (#2938)

5b02e45

Adds WORKSPACE.bazel, BUILD.bazel & *.bzl files for partial build & test with Bazel. Introduces a build-time dependency on https://github.com/rabbitmq/bazel-erlang

michaelklishin pushed a commit that referenced this pull request Apr 8, 2021

Add a partial Bazel build (#2938)

18e663c

Adds WORKSPACE.bazel, BUILD.bazel & *.bzl files for partial build & test with Bazel. Introduces a build-time dependency on https://github.com/rabbitmq/bazel-erlang

binarin pushed a commit that referenced this pull request Sep 28, 2021

Add Bazel build (#47)

d273660

Add Bazel build files corresponding to #2938 The gnu make build should remain unchanged by theses additions

binarin pushed a commit that referenced this pull request Sep 28, 2021

Add Bazel Build (#4)

3d00433

Add Bazel build files corresponding to #2938 The gnu make build should remain unchanged by theses additions

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a partial Bazel build #2938

Add a partial Bazel build #2938

HoloRin commented Mar 29, 2021 •

edited

Loading

Add a partial Bazel build #2938

Add a partial Bazel build #2938

Conversation

HoloRin commented Mar 29, 2021 • edited Loading

Proposed Changes

Types of Changes

Checklist

Further Comments

HoloRin commented Mar 29, 2021 •

edited

Loading