Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No exec or trap in rabbitmq-script-wrapper? #47

Closed
pikeas opened this issue Jan 9, 2015 · 1 comment
Closed

No exec or trap in rabbitmq-script-wrapper? #47

pikeas opened this issue Jan 9, 2015 · 1 comment
Milestone

Comments

@pikeas
Copy link

pikeas commented Jan 9, 2015

When starting RabbitMQ, the flow looks like this:

  1. /usr/sbin/rabbitmq-server (https://github.com/rabbitmq/rabbitmq-server/blob/master/packaging/common/rabbitmq-script-wrapper)
  2. /usr/lib/rabbitmq/bin/rabbitmq-server
  3. Erlang

Step 2 calls step 3 with exec. However, step 1 does not use exec when calling step 2. It also doesn't trap SIGTERM. This causes an issue downstream in dockerfile/rabbitmq, which adds a step 0 script at /usr/local/bin/rabbitmq-start:

#!/bin/bash

ulimit -n 1024
chown -R rabbitmq:rabbitmq /data
exec rabbitmq-server $@

Is there any reason why exec is missing at step 1(/usr/sbin/rabbitmq-server)? It breaks the chain, causing issues with SIGTERM handling when RabbitMQ is run in a container.

@michaelklishin
Copy link
Member

This repository is a mirror. Please post your question to rabbitmq-users.

@dumbbell dumbbell added this to the n/a milestone Mar 24, 2015
dcorbacho pushed a commit that referenced this issue May 27, 2016
Adds handling of exit signals from socket process to rabbit_reader, when terminating channels
binarin pushed a commit that referenced this issue Sep 28, 2021
Add Bazel build files corresponding to #2938

The gnu make build should remain unchanged by theses additions
dcorbacho pushed a commit that referenced this issue Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants