Skip to content

rabbitmq-upgrade await_quorum_plus_one improvements (backport #12113) (backport #12116) #12117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 25, 2024
Merged

rabbitmq-upgrade await_quorum_plus_one improvements (backport #12113) (backport #12116) #12117

merged 4 commits into from
Aug 25, 2024

Conversation

@mergify
Copy link

@mergify mergify bot commented Aug 25, 2024

  1. If khepri_db is enabled, rabbitmq_metadata is a critical component
  2. When waiting for quorum+1, periodically log what doesn't have the quorum+1
    • for components: just list them
    • for queues: list how many we are waiting for and how to display them (because there could be a large number, logging that could be impractical or even dangerous)
  3. make the tests signficantly faster by using a single group
    This is an automatic backport of pull request rabbitmq-upgrade await_quorum_plus_one improvements #12113 done by Mergify.
    This is an automatic backport of pull request rabbitmq-upgrade await_quorum_plus_one improvements (backport #12113) #12116 done by Mergify.

mkuratczyk and others added 4 commits August 25, 2024 03:04
@mkuratczyk @mergify
await quorum+1 improvements
d01059a 
1. If khepri_db is enabled, rabbitmq_metadata is a critical component
2. When waiting for quorum+1, periodically log what doesn't have the
   quorum+1
   - for components: just list them
   - for queues: list how many we are waiting for and how to display
     them (because there could be a large number, logging that
     could be impractical or even dangerous)
3. make the tests signficantly faster by using a single group

(cherry picked from commit 6ca2022)
(cherry picked from commit 547fc95)
@michaelklishin @mergify
Wording #12113
4a57eb7 
(cherry picked from commit f47daee)
(cherry picked from commit bb57273)
@michaelklishin @mergify
Update is_quorum_critical_test for #12133
fe95111 
Now the API endpoint can return Khepri as
a "queue" (or "stream") without the necessary
number of replicas online.

So don't expect the list to only have one element.

(cherry picked from commit d7d1397)
(cherry picked from commit 0644930)
@michaelklishin @mergify
Exclude this Khepri-specific test from mixed version cluster runs
52e80b3 
(cherry picked from commit 6b444ae)
(cherry picked from commit 2183140)
@michaelklishin michaelklishin added this to the 3.13.7 milestone Aug 25, 2024
@michaelklishin michaelklishin merged commit 52b3843 into v3.13.x Aug 25, 2024
@michaelklishin michaelklishin deleted the mergify/bp/v3.13.x/pr-12116 branch August 25, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.13.7

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelklishin @mkuratczyk