rabbitmq-upgrade await_quorum_plus_one improvements #12113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkuratczyk
commented
Aug 24, 2024
mkuratczyk
commented
- If khepri_db is enabled, rabbitmq_metadata is a critical component
- When waiting for quorum+1, periodically log what doesn't have the quorum+1
- for components: just list them
- for queues: list how many we are waiting for and how to display them (because there could be a large number, logging that could be impractical or even dangerous)
- make the tests signficantly faster by using a single group
michaelklishin
changed the title
1. If khepri_db is enabled, rabbitmq_metadata is a critical component
2. When waiting for quorum+1, periodically log what doesn't have the
quorum+1
- for components: just list them
- for queues: list how many we are waiting for and how to display
them (because there could be a large number, logging that
could be impractical or even dangerous)
3. make the tests signficantly faster by using a single group
michaelklishin
force-pushed
the
await-quorum-logging
branch
from
e6511c4 to
f47daee
Compare
Now the API endpoint can return Khepri as a "queue" (or "stream") without the necessary number of replicas online. So don't expect the list to only have one element.
michaelklishin
added a commit
that referenced
this pull request
Aug 25, 2024
rabbitmq-upgrade await_quorum_plus_one improvements (backport #12113)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.