Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish upkeep bullets #1905

Merged
merged 14 commits into from
Oct 31, 2023
Merged

Polish upkeep bullets #1905

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e617ebb
Polish upkeep bullets
hadley Oct 30, 2023
d2a0749
Republish at very end
hadley Oct 30, 2023
ab778b4
Don't need given
hadley Oct 30, 2023
8fbd4ed
Update snapshots
hadley Oct 30, 2023
cc2a23c
Use code for updating R min version
hadley Oct 30, 2023
b2a6f4d
Make "file an issue" a link
hadley Oct 30, 2023
68efbdb
Badges just need codecov
hadley Oct 30, 2023
a2fce6d
Might as well always update license metadata
hadley Oct 30, 2023
3e9b985
Add missing backticks
hadley Oct 30, 2023
274c0d9
Simplify logo instructions
hadley Oct 30, 2023
d52a768
Add upkeep label
hadley Oct 30, 2023
3e34838
Add missing namespace prefixes
hadley Oct 30, 2023
fc15784
More precise pak advice
hadley Oct 30, 2023
1f145ba
Put backtick in right place
hadley Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use code for updating R min version
  • Loading branch information
@hadley
hadley committed Oct 30, 2023
commit cc2a23ccc400deb268085a22a755c5ea426e26a3
2 changes: 1 addition & 1 deletion R/upkeep.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ tidy_upkeep_checklist <- function(year = NULL,
bullets,
"### Eternal",
"",
todo("Bump required R version in DESCRIPTION to {tidy_minimum_r_version()}"),
todo('`use_package("R", "Depends", "{tidy_minimum_r_version()}")`'),
todo("`usethis::use_tidy_description()`"),
todo("`usethis::use_tidy_github_actions()`"),
todo("`devtools::build_readme()`"),
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/upkeep.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@

### Eternal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 💡


* [ ] Bump required R version in DESCRIPTION to 3.6
* [ ] `use_package("R", "Depends", "3.6")`
* [ ] `usethis::use_tidy_description()`
* [ ] `usethis::use_tidy_github_actions()`
* [ ] `devtools::build_readme()`
Expand Down