Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish upkeep bullets #1905

Merged
merged 14 commits into from
Oct 31, 2023
Prev Previous commit
Next Next commit
Make "file an issue" a link
  • Loading branch information
hadley committed Oct 30, 2023
commit b2a6f4d5300f34c9e825e9c0d954b96d64954e23
7 changes: 4 additions & 3 deletions R/upkeep.R
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@ tidy_upkeep_checklist <- function(year = NULL,
"### 2023",
"",
todo(
"Update email addresses *@rstudio.com -> *@posit.co",
"
Update email addresses *@rstudio.com -> *@posit.co",
author_has_rstudio_email()
),
todo(
Expand Down Expand Up @@ -213,11 +214,11 @@ tidy_upkeep_checklist <- function(year = NULL,
todo("
Consider running `use_tidy_dependencies()` and/or \\
replace compat files with `use_standalone()`"),
todo("Use cli errors or file issue if you don\'t have time to do it now"),
todo("Use cli errors or [file an issue](new) if you don\'t have time to do it now"),
todo('
`use_standalone("r-lib/rlang", "types-check")` \\
instead of home grown argument checkers;
or file issue if you don\'t have time to do it now'),
or [file an issue](new) if you don\'t have time to do it now'),
todo(
"
Change files ending in `.r` to `.R` in R/ and/or tests/testthat/",
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/_snaps/upkeep.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@
* [ ] `usethis::use_tidy_coc()`
* [ ] Use `pak::pak("org/pkg")` in README
* [ ] Consider running `use_tidy_dependencies()` and/or replace compat files with `use_standalone()`
* [ ] Use cli errors or file issue if you don't have time to do it now
* [ ] Use cli errors or [file an issue](new) if you don't have time to do it now
* [ ] `use_standalone("r-lib/rlang", "types-check")` instead of home grown argument checkers;
or file issue if you don't have time to do it now
or [file an issue](new) if you don't have time to do it now
* [ ] Add alt-text to pictures, plots, etc; see https://posit.co/blog/knitr-fig-alt/ for examples

### Eternal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 💡

Expand Down