Clean-up: be consistent in action-reason structure to lint messages #2385
Conversation
Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>
|
OK based on initial feedback I'll continue this clean-up. |
Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2385 +/- ##
==========================================
- Coverage 98.68% 98.68% -0.01%
==========================================
Files 126 126
Lines 5714 5697 -17
==========================================
- Hits 5639 5622 -17
Misses 75 75 ☔ View full report in Codecov by Sentry. |
Co-authored-by: AshesITR <alexander.rosenstock@web.de>
Co-authored-by: AshesITR <alexander.rosenstock@web.de>
| @@ -40,7 +40,7 @@ Suggests: | |||
| httr (>= 1.2.1), | |||
| jsonlite, | |||
| mockery, | |||
| patrick, | |||
| patrick (>= 0.2.0), | |||
There was a problem hiding this comment.
this version (>1 year old) lets us get auto-named tests instead of redundantly doing .test_name = x, param = x (used in nested_ifelse_linter() here)
|
@IndrajeetPatil you have to mark your request change as fulfilled (assuming that's done) |
There was a problem hiding this comment.
@MichaelChirico Sorry, I wanted to do another pass at the PR after @AshesITR's review but I am not sure if and when I will find time and I don't want to keep this on hold.
Feel free to do so at your leisure, we can always keep iterating better messages |
Closes #1330.