Skip to content

improve handling of progress in lint_dir, expose option show_progress #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #972

@codecov-commenter
Copy link

Codecov Report

Merging #2133 (9b2a2fa) into main (9bd015d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9b2a2fa differs from pull request most recent head 6e31e3c. Consider uploading reports for the commit 6e31e3c to get more accurate results

@@           Coverage Diff           @@
##             main    #2133   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         112      112           
  Lines        5116     5125    +9     
=======================================
+ Hits         5098     5107    +9     
  Misses         18       18           
Files Changed Coverage Δ
R/lint.R 98.88% <100.00%> (+0.02%) ⬆️

@AshesITR
Copy link
Collaborator

A nice feature extension would be to somehow show the current file in such a way that generated warnings() can be attributed.

@MichaelChirico MichaelChirico merged commit 8ac582c into main Sep 11, 2023
@MichaelChirico MichaelChirico deleted the progress branch September 11, 2023 05:07
@MichaelChirico
Copy link
Collaborator Author

A nice feature extension would be to somehow show the current file in such a way that generated warnings() can be attributed.

agree it's useful... not aware of a way to do so with {utils} progress bars. eventually I think we could allow the user to supply their own progress bar like {purrr} does. for now keeping things simple -- warnings/errors ideally don't happen often (they should usually be caught as lints), so I'm happy for the quick win for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow controlling verbosity of lintr during linting
3 participants