Warn once per session, not once every 8 hours within a session #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
Oct 3, 2025
DavisVaughan
force-pushed
the
feature/no-eight-hours
branch
from
f67d71b to
fd22210
Compare
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #191, in the current release of lifecycle our "warn once every 8 hours" messaging system was not working correctly. Practically, it was only warning once per session. No one has complained about this, so we are going to move to just warning once per session unconditionally.
(Note that #191 did fix the original bug, but the fix didn't make it to CRAN yet, so it's fine to just remove it altogether)