Speed up deprecate_soft()
/ deprecate_warn()
, actually warn after 8 hours, and interpolate ({arg})
#191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3 commits here are self contained. Look at them individually to easily understand this PR.
The goal of this PR is to improve performance of
deprecate_soft()
and friends. We've been plagued by poor performance here for years, and it really hurts when used repeatedly in agroup_by()
+mutate()
where the function used inmutate()
is deprecated or has a deprecated argument.I've been able to make it ~3x faster by:
glue_data()
forsprintf()
, at the cost of ergonomics. But this is the biggest win, so I think it is worth it.arg_match()
forarg_match0()
-.POSIXct
and difftime operations when computing the 8 hour time diff, which was doing the wrong thing anyways!!I got here by analyzing this profvis output