Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced deprecated URLWhitelist #1288

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replaced deprecated URLWhitelist #1288

wants to merge 3 commits into from

Conversation

Vzor-
Copy link
Contributor

@Vzor- Vzor- commented Aug 28, 2024

Fixes #1277

@tresf

This comment was marked as outdated.

Sign in to view
@tresf
Copy link
Contributor

tresf commented Aug 29, 2024

I tested this on Windows 11 ARM64 and the popup still shows.

image

@tresf tresf self-requested a review August 29, 2024 16:00
tresf
tresf requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@tresf tresf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are needed; seems to still be broken on Windows.

@Vzor-
Copy link
Contributor Author

Vzor- commented Aug 29, 2024 •
edited
Loading

This is a working policy on MacOS
Screenshot 2024-08-29 at 2 03 14 PM
this is a not working policy on Windows.
Screenshot 2024-08-29 at 2 04 01 PM
They seem similar, but there are some minor discrepancies. I'll try resolving these to find the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tresf tresf tresf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chrome: qz:launch shows pop-up
2 participants
@Vzor- @tresf