Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome: qz:launch shows pop-up #1277

Open
tresf opened this issue Jul 16, 2024 · 2 comments · May be fixed by #1288
Open

Chrome: qz:launch shows pop-up #1277

tresf opened this issue Jul 16, 2024 · 2 comments · May be fixed by #1288
Assignees
Milestone

Comments

@tresf
Copy link
Contributor

tresf commented Jul 16, 2024

At some point, our code to suppress the qz:launch pop-ups stopped working.

Initial glance would blame the deprecation of URLWhitelist, but changing this to URLAllowlist doesn't seem to fix the symptom.

Code:

With regards to whether or not the "Always allow" checkbox is shown, there's a policy for that as well, which we don't currently configure:

Historically, we've suppressed this pop-up via policy, but recent version of Chrome seem to show this pop-up:

image
@tresf tresf added this to the 2.2.5 milestone Jul 16, 2024
@tresf tresf self-assigned this Jul 16, 2024
@Vzor-
Copy link
Contributor

Vzor- commented Aug 28, 2024

Changing line 70 to "URLAllowlist" did work for me. Do you see a policy listed under Chrome Policies on chrome://policy/

@tresf
Copy link
Contributor Author

tresf commented Aug 28, 2024

Changing line 70 to "URLAllowlist" did work for me. Do you see a policy listed under Chrome Policies on chrome://policy/

Great, let's get a PR prepared and then we can retest.

@Vzor- Vzor- linked a pull request Aug 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants