Skip to content

Commit

Permalink
Apply NOT_TAIL_CALLED to ~CheckError
Browse files Browse the repository at this point in the history
This is a speculative fix for crash-report frames that look similar to:
  check.cc:206  ui::CompositorAnimationObserver::NotifyFailure()

Hopefully this should be sufficient to preserve the (D)CHECK call site.

Bug: None
Change-Id: Id3c47e29f693167db1c030bfd0c8e1aedfb9e950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3861194
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1040528}
  • Loading branch information
pbos authored and Chromium LUCI CQ committed Aug 29, 2022
1 parent 3051bd7 commit d7080b2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion base/check.h
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class BASE_EXPORT CheckError {
// Stream for adding optional details to the error message.
std::ostream& stream();

NOMERGE ~CheckError();
NOMERGE NOT_TAIL_CALLED ~CheckError();

CheckError(const CheckError&) = delete;
CheckError& operator=(const CheckError&) = delete;
Expand Down

0 comments on commit d7080b2

Please sign in to comment.