Skip to content

Commit

Permalink
[sheriff] Disable PDFExtensionSaveWithPolicyTest.SaveWithPolicyUnique…
Browse files Browse the repository at this point in the history
…TimeSuffix.

Bug: 1269103
Change-Id: I3cb29b960eab3b4337aa3d389b3010e41aa773c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3860219
Auto-Submit: Francois Pierre Doray <fdoray@chromium.org>
Commit-Queue: Francois Pierre Doray <fdoray@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1040527}
  • Loading branch information
fdoray authored and Chromium LUCI CQ committed Aug 29, 2022
1 parent ece5aa2 commit 3051bd7
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions chrome/browser/pdf/pdf_extension_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3201,15 +3201,9 @@ IN_PROC_BROWSER_TEST_F(PDFExtensionSaveWithPolicyTest,
WaitForSavedPdf(save_path);
}

// Flaky, http://crbug.com/1269103
#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_WIN) || BUILDFLAG(IS_CHROMEOS)
#define MAYBE_SaveWithPolicyUniqueTimeSuffix \
DISABLED_SaveWithPolicyUniqueTimeSuffix
#else
#define MAYBE_SaveWithPolicyUniqueTimeSuffix SaveWithPolicyUniqueTimeSuffix
#endif
// TODO(crbug.com/1269103): Make this test non-flaky.
IN_PROC_BROWSER_TEST_F(PDFExtensionSaveWithPolicyTest,
MAYBE_SaveWithPolicyUniqueTimeSuffix) {
DISABLED_SaveWithPolicyUniqueTimeSuffix) {
base::ScopedAllowBlockingForTesting allow_blocking;

CreateConflictingFilenames(GetDownloadDir().AppendASCII("combobox_form.pdf"),
Expand Down

0 comments on commit 3051bd7

Please sign in to comment.