Skip to content

fix: Cannot build quick perf from sources #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: Cannot build quick perf from sources #223

wants to merge 2 commits into from

Conversation

nagyesta
Copy link
Contributor

  • Replace missing flight recorder dependency with latest version
  • Remove unused Maven repository
  • Update various dependencies
  • Update minimum JDK version to 17
  • Fix code that broke because of the updates
  • Update CI pipeline to use valid JDK versions

Resolves #220

@nagyesta nagyesta mentioned this pull request May 20, 2025
Closed
@nagyesta
fix: Cannot build quick perf from sources
54249ab 
- Replace missing flight recorder dependency with latest version
- Remove unused Maven repository
- Update various dependencies
- Update minimum JDK version to 17
- Fix code that broke because of the updates
- Update CI pipeline to use valid JDK versions
- Update build actions

Resolves quick-perf#220

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
@nagyesta nagyesta force-pushed the 220-cannot-build-master branch from e73bd7d to 54249ab Compare May 20, 2025 20:57
jeanbisutti
jeanbisutti reviewed May 20, 2025
View reviewed changes
Copy link
Collaborator

@jeanbisutti jeanbisutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @nagyesta!

Perhaps only the Java version of the jfr-annotations artifact could be updated?

Upgrading the Java version of all the artifacts would require to release a new major version.

@nagyesta nagyesta force-pushed the 220-cannot-build-master branch 2 times, most recently from b418a98 to 095e41b Compare May 20, 2025 21:17
@nagyesta
fix: Cannot build quick perf from sources
f5b30b0 
- Attempt to fix broken build

Resolves quick-perf#220

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
@nagyesta nagyesta force-pushed the 220-cannot-build-master branch from 095e41b to f5b30b0 Compare May 20, 2025 21:26
@nagyesta
Copy link
Contributor Author

Thanks a lot @nagyesta!

Perhaps only the Java version of the jfr-annotations artifact could be updated?

Upgrading the Java version of all the artifacts would require to release a new major version.

Thank you for the review! I will take a look and revert the unnecessary JDK version updates where possible.

@nagyesta
Copy link
Contributor Author

Hi @jeanbisutti ,
I have reverted everything I could, but these remaining few modules depend on the JVM module so they all had to be migrated to JDK 17 unfortunately.
Please let me know whether it is okay or not!

@nagyesta nagyesta requested a review from jeanbisutti May 21, 2025 19:21
@nagyesta
Copy link
Contributor Author

Actually I think I will open a new PR because something is broken with this one.

@nagyesta nagyesta closed this May 21, 2025
@nagyesta nagyesta deleted the 220-cannot-build-master branch May 21, 2025 19:25
@nagyesta
Copy link
Contributor Author

The new one is #224
(I had a typo in the branch name at some point)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbisutti jeanbisutti Awaiting requested review from jeanbisutti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot build quick perf from sources
2 participants
@nagyesta @jeanbisutti