fix: Cannot build quick perf from sources #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
reviewed
May 21, 2025
nagyesta
force-pushed
the
220-cannot-build-master-minimal
branch
2 times, most recently
from
28c9cfe to
6a7f1d1
Compare
- Replace missing flight recorder dependency with 8.3.1 - Remove unused Maven repository - Update minimum JDK version to 1.8 for JVM module - Fix code that broke because of the updates - Update CI pipeline to use updated versions Resolves quick-perf#220 Signed-off-by: Esta Nagy <nagyesta@gmail.com>
nagyesta
force-pushed
the
220-cannot-build-master-minimal
branch
from
6a7f1d1 to
58bbfb5
Compare
jeanbisutti
reviewed
May 22, 2025
jvm/jfr-annotations/src/main/java/org/quickperf/jvm/jmcrule/JmcRuleCountMeasureExtractor.java
Show resolved
Hide resolved
- Review fixes Resolves quick-perf#220 Signed-off-by: Esta Nagy <nagyesta@gmail.com>
|
Thanks @nagyesta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #220