Rewrite multiple persistence unit documentation section for Hibernate Reactive #49287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
🙈 The PR is closed and the preview is expired. |
yrodiere
reviewed
Aug 1, 2025
| %prod.quarkus.datasource."named-datasource".username" = quarkus_test | ||
| %prod.quarkus.datasource."named-datasource".password" = quarkus_test | ||
| %prod.quarkus.datasource.reactive.url = vertx-reactive:postgresql://localhost/quarkus_test <1> | ||
| quarkus.datasource."users".reactive=true <1> |
There was a problem hiding this comment.
Are you sure this is necessary? It's the default...
| quarkus.datasource."users".username=hibernate_orm_test<1> Define a datasource named `users`. | ||
| quarkus.datasource."users".password=hibernate_orm_test | ||
|
|
||
| quarkus.datasource."inventory".reactive=true <2> |
There was a problem hiding this comment.
Are you sure this is necessary? It's the default...
| quarkus.datasource."inventory".username=hibernate_orm_test | ||
| quarkus.datasource."inventory".password=hibernate_orm_test | ||
|
|
||
| quarkus.hibernate-orm."users".schema-management.strategy=drop-and-create <3> |
There was a problem hiding this comment.
I believe you sent other PRs previously, at my request, to avoid this kind of configuration which could result in a production database being dropped :)
Maybe see how it's done in quickstarts or the ORM documentation?
lucamolteni
force-pushed
the
46727-documentation
branch
from
f28bf86 to
844473e
Compare
Status for workflow
|
gsmet
approved these changes
Aug 8, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #47631 (comment)
Original PR was missing the updates to the documentation
#46727 (comment)