Skip to content

Enable named data sources for Hibernate Reactive #47631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

Enable named data sources for Hibernate Reactive #47631

merged 1 commit into from
May 12, 2025

Conversation

lucamolteni
Copy link
Contributor

@lucamolteni lucamolteni commented Apr 30, 2025 •
edited
Loading

The named data source part for #46727

I know we discussed doing named PU together, but this works already and the changes seems easy to understand so I wanted to try create the smaller one first.

this one was supposed to be done together as well but it doesn't seem to be related to named-datasource so I assume it's related to named persistent units.

@lucamolteni lucamolteni requested review from yrodiere and gsmet April 30, 2025 14:52
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2025 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
yrodiere
yrodiere reviewed May 5, 2025
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I spotted a few things in the docs and logs/error messages (see below), but otherwise the approach seems sound.

@yrodiere
Copy link
Member

yrodiere commented May 5, 2025

this one was supposed to be done together as well but it doesn't seem to be related to named-datasource so I assume it's related to named persistent units.

Yep, it's about PUs.

@lucamolteni lucamolteni mentioned this pull request May 6, 2025
Closed
@lucamolteni lucamolteni force-pushed the 46727-without-conf-name branch from 09a6cc6 to 0015b7b Compare May 6, 2025 15:01
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
yrodiere
yrodiere approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Let's squash and merge?

@lucamolteni
Enable named data source for hibernate reactive
d47f5b6 
* Changed error message / log to avoid using the default data source
* Align FastBootHibernateReactivePersistenceProvider to FastBootHibernateReactivePersistenceProvider
@lucamolteni lucamolteni force-pushed the 46727-without-conf-name branch from 65857b0 to d47f5b6 Compare May 8, 2025 08:50
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented May 8, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit d47f5b6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented May 8, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d47f5b6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@lucamolteni
Copy link
Contributor Author

LGTM, thanks. Let's squash and merge?

@gsmet

@yrodiere yrodiere merged commit 96640d8 into quarkusio:main May 12, 2025
36 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.23 - main milestone May 12, 2025
@gsmet gsmet changed the title Enable named data sources for hibernate reactive Enable named data sources for Hibernate Reactive May 28, 2025
@lucamolteni lucamolteni mentioned this pull request Aug 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/documentation area/hibernate-reactive Hibernate Reactive release/noteworthy-feature
Projects
None yet
Milestone
3.23.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@lucamolteni @yrodiere @gsmet