Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vert.x: fix NPE in ForwardedProxyHandler #36682

Merged
merged 1 commit into from
Oct 25, 2023

Commits on Oct 25, 2023

  1. Vert.x: fix NPE in ForwardedProxyHandler

    The test `TrustedXForwarderProxiesUnknownHostnameFailureTest` sometimes fail
    in CI due to a NPE in `ForwardedProxyHandler`. This shows an actual bug:
    per the documentation, `io.vertx.core.dns.DnsClient.lookup()` may succeed
    with a `null` value when no record was found. The `ForwardedProxyHandler`
    ignores the possibility of a `null` result, which this commit fixes. We deal
    with a `null` result just like with a failure, because it's equivalent
    to a NXDOMAIN error.
    Ladicek committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    985e78e View commit details
    Browse the repository at this point in the history