Vert.x: fix NPE in ForwardedProxyHandler

[Ladicek]

The test TrustedXForwarderProxiesUnknownHostnameFailureTest sometimes fail in CI due to a NPE in ForwardedProxyHandler. This shows an actual bug: per the documentation, io.vertx.core.dns.DnsClient.lookup() may succeed with a null value when no record was found. The ForwardedProxyHandler ignores the possibility of a null result, which this commit fixes. We deal with a null result just like with a failure, because it's equivalent to a NXDOMAIN error.

Fixes #36656

[Ladicek]

See #36310 (comment) for motivation.

[michalvavrik]

Thanks!

[gsmet]

@Ladicek woot! Could you adjust the description to mention it fixes #36656 ?

[sberyozkin]

Good catch, thanks

[Ladicek]

Huh, I didn't even bother checking if we have a report for this :-) Thanks @gsmet, added to the description.

[gsmet]

Yeah, I'm trying to improve the CI situation so fixing tests, disabling some and creating issues. I hope we will get in a better state soon.

[quarkus-bot]

Failing Jobs - Building 985e78e

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 17	Build	⚠️ Check →	Logs	Raw logs
✔️	JVM Tests - JDK 21
✔️	Maven Tests - JDK 11
✖	Maven Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven 

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)