Add reset to QASM parser

[rscircus]

This PR solves #6704

Note / 20240914:

After further inspection, I wonder why resets are implemented quite different to regular gates, despite following a somewhat similar terminology (cirq.R or cirq.reset) however, returning a ResetChannel. It appears to me that the reset is more similar to a measurement than compared to say a Hadamard gate.

[rscircus]

Rebased on top of main.

[rscircus]

Squashing everything into one commit after we finish review. Thus I leave the generic 'Fix comments & typos' as it is for now.

[rscircus]

Hey guys, you have any feedback on the solution proposal here?

[natestemen]

My review doesn't mean much, since I'm not very familiar with this codebase, but the diff looks reasonable! Hope this can get reviewed by a cirq maintainer soon :)

[dstrain115]

It looks like there is an error in the parser:

ERROR: /home/runner/work/Cirq/Cirq/cirq-core/cirq/contrib/qasm_import/_parser.py:508: Symbol 'qreg' used, but not defined as a token or a rule

Also, please run check/formatting in order to pass the format check.

[gluonhiggs]

It looks like there is an error in the parser:

ERROR: /home/runner/work/Cirq/Cirq/cirq-core/cirq/contrib/qasm_import/_parser.py:508: Symbol 'qreg' used, but not defined as a token or a rule

Also, please run check/formatting in order to pass the format check.

Hello everyone, is there anything remaining to address in this PR before it can be finalized?

[pavoljuhas]

@rscircus - thank you for contributing this and apologies for slow response.

I have fixed the typo in parser definition and complaints from format checker.
I also added a test of the reset instruction with OpenQASM 3.

Please take a look if you are fine with the PR as is. LGTM from my POV.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (d760f00) to head (066d4ae).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6710      +/-   ##
==========================================
- Coverage   97.85%   97.85%   -0.01%     
==========================================
  Files        1084     1084              
  Lines       93742    93758      +16     
==========================================
+ Hits        91733    91745      +12     
- Misses       2009     2013       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rscircus]

Thanks. I'll pull at the weekend and give it a final run.

[pavoljuhas]

Thanks. I'll pull at the weekend and give it a final run.

I have merged, hope it is OK. LMK if you see anything amiss and we can address it in a follow-up PR.

[rscircus]

Thanks, @pavoljuhas