-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom gate defintions in QASM parser #6917
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6917 +/- ##
========================================
Coverage 97.87% 97.87%
========================================
Files 1084 1084
Lines 94420 94791 +371
========================================
+ Hits 92409 92780 +371
Misses 2011 2011 ☔ View full report in Codecov by Sentry. |
fe19f08
to
8a7727f
Compare
8a7727f
to
a337aed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really cool enhancement to qasm parsing!!!
Just some doc comments, and then I think we are good to go.
Resolves #3560
assert_qiskit_parsed_qasm_consistent_with_unitary
to ensure consistency of parsed circuit (and sanity check that the provided QASM definition is actually valid).