Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebooks guide #3781

Merged
merged 12 commits into from
Feb 12, 2021
Merged

Notebooks guide #3781

merged 12 commits into from
Feb 12, 2021

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Feb 10, 2021

Adds guidance on styling and development of notebooks.

@balopat balopat requested review from cduck, vtomole and a team as code owners February 10, 2021 17:49
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Feb 10, 2021
@balopat balopat mentioned this pull request Feb 10, 2021
Merged
95-martin-orion
95-martin-orion requested changes Feb 10, 2021
View reviewed changes
docs/dev/notebooks.md Outdated Show resolved Hide resolved
docs/dev/notebooks.md Outdated Show resolved Hide resolved
docs/dev/notebooks.md Show resolved Hide resolved
docs/dev/notebooks.md Outdated Show resolved Hide resolved
docs/dev/notebooks.md Outdated Show resolved Hide resolved
docs/dev/notebooks.md Outdated Show resolved Hide resolved
docs/dev/notebooks.md Outdated Show resolved Hide resolved
docs/dev/notebooks.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
@balopat
Copy link
Contributor Author

balopat commented Feb 11, 2021

Thanks for the thorough review @95-martin-orion, you rock! I resolved all your comments!

95-martin-orion
95-martin-orion requested changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more small fixes.

docs/_template.ipynb Outdated Show resolved Hide resolved
docs/dev/notebooks.md Outdated Show resolved Hide resolved
docs/dev/notebooks.md Outdated Show resolved Hide resolved
95-martin-orion
95-martin-orion approved these changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final item, but otherwise this LGTM!

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 11, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 11, 2021
@CirqBot
Copy link
Collaborator

CirqBot commented Feb 11, 2021

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Feb 11, 2021
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 12, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 12, 2021
@CirqBot CirqBot merged commit bbf6245 into quantumlib:master Feb 12, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Feb 12, 2021
@mpharrigan mpharrigan mentioned this pull request Feb 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BichengYing BichengYing BichengYing left review comments

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balopat @CirqBot @BichengYing @95-martin-orion