[XEB] Split into three files #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
requested review from
cduck,
mrwojtek,
vtomole and
a team
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mpharrigan
commented
Feb 12, 2021
Comment on lines
+53
to
+55
| This uses the estimator from | ||
| `cirq.experiments.fidelity_estimation.least_squares_xeb_fidelity_from_expectations`, but | ||
| adapted for use on pandas DataFrames for efficient vectorized operation. |
There was a problem hiding this comment.
this is a new note
balopat
approved these changes
Feb 12, 2021
|
LGTM, previously reviewed on your fork. The reorg makes sense to me and the new note looks good too. |
|
I can't reproduce the notebook test failure locally. It looks unrelated, as it's in the "against stable cirq" tests, which should exclude all the xeb notebooks |
|
Might have been a race condition with merging #3781 |
|
@mrwojtek I'm going to merge this so I can send out my next PR for you to review tonight (/your morning). If you have objections to this move, I can fix it up later! |
mpharrigan
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is purely moving things around (on top of #3760) with one exception noted inline.
random_quantum_circuit_generation-- left alone; this is a well-scoped filexeb_sampling- functionality related to sampling random circuits efficiently (for xeb)xeb_simulation- functionality related to simulating 2-qubit circuits at various depths (for xeb) efficiently using multiprocessingxeb_fitting- functionality related to using xeb to characterize gates by fitting parameters.