Skip to content

Conversation

freddiev4
Copy link
Contributor

No description provided.

Copy link
Member

@richafrank richafrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice @freddiev4 ! I just saw one line that could be improved.

~~~~~~~~~~

None
Since the the release of Zipline ``1.1.0``, Quantopian has officially released support for Futures in Zipline, as well as Python 3.5 support.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a reader, I find "since 1.1.0" ambiguous: does it mean these are features that first appeared in 1.1.0, or features that first appeared after 1.1.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could just say "After the release of Zipline 1.1.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about "Zipline now has broad support for futures, in addition to equities. It's also being tested and packaged for Python 3.5.", ignoring official-ness or the version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 😄

@coveralls
Copy link

coveralls commented Jun 30, 2017

Coverage Status

Coverage remained the same at 87.683% when pulling 5a76c57 on zipline-1.1.1 into 5e6110e on master.

@coveralls
Copy link

coveralls commented Jun 30, 2017

Coverage Status

Coverage remained the same at 87.683% when pulling 82ad305 on zipline-1.1.1 into 5e6110e on master.

@coveralls
Copy link

coveralls commented Jun 30, 2017

Coverage Status

Coverage remained the same at 87.683% when pulling 82ad305 on zipline-1.1.1 into 5e6110e on master.

@freddiev4
Copy link
Contributor Author

@richafrank also generated type stubs

@coveralls
Copy link

coveralls commented Jun 30, 2017

Coverage Status

Coverage remained the same at 87.52% when pulling ff8a9d5 on zipline-1.1.1 into 5343344 on master.

@richafrank
Copy link
Member

Thanks for that!

@coveralls
Copy link

coveralls commented Jul 5, 2017

Coverage Status

Coverage decreased (-0.03%) to 87.492% when pulling f5e7fcf on zipline-1.1.1 into 5343344 on master.

@freddiev4 freddiev4 merged commit 9d01ba7 into master Jul 5, 2017
@freddiev4 freddiev4 deleted the zipline-1.1.1 branch July 5, 2017 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants