MAINT: Remove deprecated Yahoo code #1867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddiev4
force-pushed
the
remove-deprecated-yahoo-code
branch
from
e71d56c to
fd3e453
Compare
richafrank
reviewed
Jun 30, 2017
| # as we use in test_examples.py. | ||
| environ = {'ZIPLINE_ROOT': d.getpath('example_data/root')} | ||
| if rebuild_input: | ||
| rebuild_input_data(environ) |
There was a problem hiding this comment.
Do the tests no longer rely on this input data? Or how should we rebuild it from now on?
There was a problem hiding this comment.
We'll need to switch it to use a different bundle, so for now if someone passes the --rebuild-input flag we raise a StandardErrorand let users know that this will be fixed in a future release
DOC: Remove mentions of Yahoo data bundles MAINT: Remove yahoo bundle, test, and more mentions of yahoo
freddiev4
force-pushed
the
remove-deprecated-yahoo-code
branch
from
e70b91a to
d4d8db3
Compare
|
@richafrank mind giving this one more pass? |
richafrank
reviewed
Jul 3, 2017
tests/resources/rebuild_example_data
Outdated
| ingest(TEST_BUNDLE_NAME, environ=environ, show_progress=True) | ||
| clean(TEST_BUNDLE_NAME, keep_last=1, environ=environ) | ||
| @click.command() | ||
| @click.option( |
There was a problem hiding this comment.
Looks like there's an extra character of indentation.
tests/resources/rebuild_example_data
Outdated
|
|
||
| if rebuild_input: | ||
| rebuild_input_data(environ) | ||
| raise StandardError( |
There was a problem hiding this comment.
Maybe NotImplementedError? My preference is definitely for more specific error types when possible.
| cache for `symbol` whose first entry is before or on `first_date` and whose | ||
| last entry is on or after `last_date`. | ||
| If we perform a download and the cache criteria are not satisfied, we wait |
freddiev4
force-pushed
the
remove-deprecated-yahoo-code
branch
2 times, most recently
from
ac1c859 to
552c142
Compare
freddiev4
force-pushed
the
remove-deprecated-yahoo-code
branch
from
552c142 to
492b22f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a little ambitious, but trying to sneak this in before #1868 gets merged and before our next release.
Also #1845