[RISCV] Implement Relaxations for QC.E.J/QC.E.JAL #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-seaswara
requested changes
Jun 10, 2025
Contributor
quic-seaswara
left a comment
quic-seaswara
left a comment
There was a problem hiding this comment.
Can you add a reference to the ABI that describes the relaxation in the commit message ?
test/RISCV/standalone/Relaxation/QC_E_CALL_TO_JAL/QC_E_CALL_TO_JAL.test
Outdated
Show resolved
Hide resolved
test/RISCV/standalone/Relaxation/QC_E_CALL_TO_JAL/QC_E_CALL_TO_JAL_PLT.test
Show resolved
Hide resolved
test/RISCV/standalone/Relaxation/QC_E_CALL_TO_JAL/QC_E_CALL_TO_JAL_PLT.test
Outdated
Show resolved
Hide resolved
5 tasks
quic-seaswara
approved these changes
Jun 17, 2025
quic-seaswara
requested review from
quic-akaryaki
and removed request for
quic-akaryaki
These relaxations are like call relaxations, so they are done in the same phase as call relaxations. The Relaxations are: - QC.E.J to C.J or JAL X0 - QC.E.JAL to C.JAL or JAL X1 This change also adds a command-line switch for turning off all the xqci relaxations, which defaults to Off. Signed-off-by: Sam Elliott <quic_aelliott@quicinc.com>
quic-seaswara
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These relaxations are like call relaxations, so they are done in the same phase as call relaxations.
The Relaxations are:
This change also adds a command-line switch for turning off all the xqci relaxations.
These relaxations are described in http://github.com/quic/riscv-elf-psabi-quic-extensions/releases/latest
This is the first commit to implement #147 so includes adding the flag as well.