Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python-based PDD solver option and fix sign convention inconsistencies #265

Merged
merged 27 commits into from
Nov 19, 2023

Further Sesame changes

692c986
Select commit
Loading
Failed to load commit list.
Merged

Add Python-based PDD solver option and fix sign convention inconsistencies #265

Further Sesame changes
692c986
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 19, 2023 in 1s

93.65% of diff hit (target 57.25%)

View this Pull Request on Codecov

93.65% of diff hit (target 57.25%)

Annotations

Check warning on line 177 in solcore/analytic_solar_cells/depletion_approximation.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/analytic_solar_cells/depletion_approximation.py#L177 

Added line #L177 was not covered by tests

Check warning on line 182 in solcore/analytic_solar_cells/depletion_approximation.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/analytic_solar_cells/depletion_approximation.py#L182 

Added line #L182 was not covered by tests

Check warning on line 51 in solcore/material_data/mobility.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/material_data/mobility.py#L51 

Added line #L51 was not covered by tests

Check warning on line 300 in solcore/poisson_drift_diffusion/DriftDiffusionUtilities.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/poisson_drift_diffusion/DriftDiffusionUtilities.py#L300 

Added line #L300 was not covered by tests

Check warning on line 12 in solcore/poisson_drift_diffusion/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/poisson_drift_diffusion/__init__.py#L12 

Added line #L12 was not covered by tests

Check warning on line 337 in solcore/sesame_drift_diffusion/process_structure.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/sesame_drift_diffusion/process_structure.py#L337 

Added line #L337 was not covered by tests

Check warning on line 399 in solcore/sesame_drift_diffusion/process_structure.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/sesame_drift_diffusion/process_structure.py#L399 

Added line #L399 was not covered by tests

Check warning on line 421 in solcore/sesame_drift_diffusion/process_structure.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/sesame_drift_diffusion/process_structure.py#L421 

Added line #L421 was not covered by tests

Check warning on line 28 in solcore/sesame_drift_diffusion/solve_pdd.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/sesame_drift_diffusion/solve_pdd.py#L28 

Added line #L28 was not covered by tests

Check warning on line 32 in solcore/sesame_drift_diffusion/solve_pdd.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/sesame_drift_diffusion/solve_pdd.py#L31-L32 

Added lines #L31 - L32 were not covered by tests

Check warning on line 34 in solcore/sesame_drift_diffusion/solve_pdd.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/sesame_drift_diffusion/solve_pdd.py#L34 

Added line #L34 was not covered by tests

Check warning on line 37 in solcore/sesame_drift_diffusion/solve_pdd.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/sesame_drift_diffusion/solve_pdd.py#L36-L37 

Added lines #L36 - L37 were not covered by tests

Check warning on line 41 in solcore/sesame_drift_diffusion/solve_pdd.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/sesame_drift_diffusion/solve_pdd.py#L41 

Added line #L41 was not covered by tests

Check warning on line 43 in solcore/sesame_drift_diffusion/solve_pdd.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/sesame_drift_diffusion/solve_pdd.py#L43 

Added line #L43 was not covered by tests

Check warning on line 214 in solcore/sesame_drift_diffusion/solve_pdd.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/sesame_drift_diffusion/solve_pdd.py#L214 

Added line #L214 was not covered by tests

Check warning on line 326 in solcore/sesame_drift_diffusion/solve_pdd.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/sesame_drift_diffusion/solve_pdd.py#L326 

Added line #L326 was not covered by tests

Check warning on line 172 in solcore/solar_cell_solver.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/solar_cell_solver.py#L171-L172 

Added lines #L171 - L172 were not covered by tests

Check warning on line 229 in solcore/solar_cell_solver.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/solar_cell_solver.py#L228-L229 

Added lines #L228 - L229 were not covered by tests

Check warning on line 356 in solcore/solar_cell_solver.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/solar_cell_solver.py#L356 

Added line #L356 was not covered by tests

Check warning on line 362 in solcore/solar_cell_solver.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

solcore/solar_cell_solver.py#L362 

Added line #L362 was not covered by tests
View more details on Codecov