Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python-based PDD solver option and fix sign convention inconsistencies #265

Merged
merged 27 commits into from
Nov 19, 2023
Merged

Add Python-based PDD solver option and fix sign convention inconsistencies #265

merged 27 commits into from
Nov 19, 2023

Commits on Oct 14, 2023

  1. sesame testing, add folder and files for sesame

    @phoebe-p
    phoebe-p committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    19f73a2 View commit details
    Browse the repository at this point in the history

  2. processing materials for sesame

    @phoebe-p
    phoebe-p committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    247f978 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. outline of sesame IV and QE methods

    @phoebe-p
    phoebe-p committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    48d763f View commit details
    Browse the repository at this point in the history

  2. iv_sesame seems to be working (outputs not yet in right format)

    @phoebe-p
    phoebe-p committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    369ed49 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. add sesame to requirements, add example. QE and IV working

    @phoebe-p
    phoebe-p committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    709b087 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. QE and IV calculation working for Si

    @phoebe-p
    phoebe-p committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    223695d View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. fix bug with NaN in IV results, fix bug in GaAsN bowing parameter data

    @phoebe-p
    phoebe-p committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    f2eac22 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. adding tests and examples

    @phoebe-p
    phoebe-p committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    cbdebb8 View commit details
    Browse the repository at this point in the history

  2. adding build for Python 3.12, updating automated test Python versions

    @phoebe-p
    phoebe-p committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    70a709a View commit details
    Browse the repository at this point in the history

  3. newer version of cibuildwheel

    @phoebe-p
    phoebe-p committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    9efdf84 View commit details
    Browse the repository at this point in the history

  4. try to fix BLAS issue

    @phoebe-p
    phoebe-p committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    7ed0502 View commit details
    Browse the repository at this point in the history

  5. try to fix BLAS issue

    @phoebe-p
    phoebe-p committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    1372de7 View commit details
    Browse the repository at this point in the history

  6. try to fix BLAS issue

    @phoebe-p
    phoebe-p committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    61e4d5d View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. identified issue with signs

    @phoebe-p
    phoebe-p committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    5b4e684 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. DA/PDD voltage direction issue seems to be fixed

    @phoebe-p
    phoebe-p committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    3cbc296 View commit details
    Browse the repository at this point in the history

  2. DA and PDD have same sign conventions

    @phoebe-p
    phoebe-p committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    78dfc00 View commit details
    Browse the repository at this point in the history

  3. updated test for new DA sign convention

    @phoebe-p
    phoebe-p committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    6a33c6d View commit details
    Browse the repository at this point in the history

  4. calculate lifetime or diffusion length from mobility and the other qu… 

    …antity
    @phoebe-p
    phoebe-p committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    0e83d69 View commit details
    Browse the repository at this point in the history

  5. modify examples. Add error for decreasing voltages and internal_voltages

    @phoebe-p
    phoebe-p committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    bd66158 View commit details
    Browse the repository at this point in the history

  6. add warning for wrong voltage sign to DA solver

    @phoebe-p
    phoebe-p committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b8e5120 View commit details
    Browse the repository at this point in the history

  7. update ARC RAT example

    @phoebe-p
    phoebe-p committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e875d73 View commit details
    Browse the repository at this point in the history

  8. add Si cell example. Check material files for recombination propertie… 

    …s before calculating
    @phoebe-p
    phoebe-p committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    884febb View commit details
    Browse the repository at this point in the history

  9. update tests and examples. Make parallel implementation of eqe possible

    @phoebe-p
    phoebe-p committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    a7fdc05 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. fix failing tests

    @phoebe-p
    phoebe-p committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    2900bce View commit details
    Browse the repository at this point in the history

  2. fix failing tests

    @phoebe-p
    phoebe-p committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    a7a4c7a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'update_build_312' into pdd_sesame

    @phoebe-p
    phoebe-p committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    e6f8683 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Further Sesame changes 

    - Refactor Sesame PDD into two files, update tests and documentation/docstrings
- Remove changes to material_system causing recursion/stack overflow errors
- add type annotations and docstrings. Black formatting
- fix DA dark current overflow and relevant test
- Improve automatic mesh for Sesame PDD
- update documentation, add tests
- make labelling of SRVs consistent between DA and Sesame.
- remove GitHub reference for Sesame installation, refer to new PyPI version
- Update outdated examples
- Fix issue where plotting error causing examples in GitHub actions to fail
- Change build for S4 to install setuptools explicitly (necessary in Python 3.12)
- Sesame now scans from long to short wavelengths in QE calculations to improve changes of convergence, and skips wavelengths where absorption = 0
- Fix issue where Fortran PDD did not work if all voltages < 0
- Upgrade from devpy to spin (renamed), and to latest version of meson in the build system
    @phoebe-p
    phoebe-p committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    692c986 View commit details
    Browse the repository at this point in the history