Skip to content

Conversation

@tomerqodo
Copy link

Benchmark PR langgenius#31069

Type: Corrupted (contains bugs)

Original PR Title: refactor: always preserve marketplace search state in URL
Original PR Description: ## Summary

Remove preserveSearchStateInQueryAtom and always preserve marketplace search state in the URL.

The marketplace was conditionally using either Jotai atoms or URL query state based on preserveSearchStateInQueryAtom. This PR simplifies the logic by always using URL query state.

Also fixes a key conflict where both plugin page tabs and marketplace plugin type filter were using category as the query param key. Renamed marketplace's param to type to resolve this.

Fixes langgenius#31030

Screenshots

Before After
N/A - No visual changes N/A - No visual changes

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=4217675

Original PR URL: langgenius#31069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants