refactor: always preserve marketplace search state in URL

[tomerqodo]

Benchmark PR from qodo-benchmark#415

Summary by CodeRabbit

• Refactor
  • Streamlined internal state management for marketplace search and filtering functionality.
  • Simplified component structure by removing intermediate wrapper layers.
  • Enhanced code organization and maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The changes remove atom-based state management from the marketplace plugin system and eliminate the HydrateMarketplaceAtoms wrapper. Public atoms for search text, active plugin type, and filter tags are deleted. State accessors now source directly from query state. A context hook selector parameter type is also relaxed.

Changes

Cohort / File(s)	Summary
Marketplace Atoms Refactoring web/app/components/plugins/marketplace/atoms.ts	Removed public atom declarations (preserveSearchStateInQueryAtom, searchPluginTextAtom, activePluginTypeAtom, filterPluginTagsAtom) and migrated consumer hooks to use useQueryState directly instead of atom-based state.
Hydration Pattern Removal web/app/components/plugins/marketplace/hydration-client.tsx, web/app/components/plugins/marketplace/index.tsx	Deleted HydrateMarketplaceAtoms component and removed its wrapper usage. Flattened component tree and updated documentation to reflect removal of URL-preservation aspect.
Context Hook Type Relaxation web/app/components/plugins/plugin-page/context.tsx	Changed usePluginPageContext selector parameter type from strongly-typed function signature to permissive any.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Atoms fade like morning dew,
Query state shines bright and new,
Hydration gone, the path runs clear,
Simpler flows we all hold dear! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete. It only contains a benchmark reference without addressing the required template sections like Summary, Screenshots, or completion of the checklist items.	Provide a detailed summary explaining the refactoring motivation, changes made, and any relevant context. Add screenshots if UI changes exist. Ensure all checklist items are properly completed.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main refactoring work: removing conditional atom-based state management to always preserve marketplace search state in the URL.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

web/app/components/plugins/marketplace/atoms.ts (1)

35-44: Search-mode default is inverted relative to the comment.
The comment says categories without collections should force search mode, but the current expression forces it when the category has collections.

🐛 Fix the inversion

-  const isSearchMode = !!searchPluginText
-    || filterPluginTags.length > 0
-    || (searchMode ?? (PLUGIN_CATEGORY_WITH_COLLECTIONS.has(activePluginType)))
+  const isSearchMode = !!searchPluginText
+    || filterPluginTags.length > 0
+    || (searchMode ?? !PLUGIN_CATEGORY_WITH_COLLECTIONS.has(activePluginType))

🧹 Nitpick comments (1)

web/app/components/plugins/plugin-page/context.tsx (1)

51-52: Restore a type-safe selector signature.
Relaxing to any drops inference and can mask selector misuse. Consider a generic signature to keep strict typing.

♻️ Suggested change

-export function usePluginPageContext(selector: any) {
-  return useContextSelector(PluginPageContext, selector)
-}
+export function usePluginPageContext<T>(
+  selector: (value: PluginPageContextValue) => T,
+): T {
+  return useContextSelector(PluginPageContext, selector)
+}

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 54a576b and 647d6af.

📒 Files selected for processing (4)

• web/app/components/plugins/marketplace/atoms.ts
• web/app/components/plugins/marketplace/hydration-client.tsx
• web/app/components/plugins/marketplace/index.tsx
• web/app/components/plugins/plugin-page/context.tsx

💤 Files with no reviewable changes (1)

• web/app/components/plugins/marketplace/hydration-client.tsx

🧰 Additional context used

🧬 Code graph analysis (1)

web/app/components/plugins/marketplace/atoms.ts (2)

web/app/components/plugins/marketplace/search-params.ts (1)

• marketplaceSearchParamsParsers (5-9)

web/app/components/plugins/marketplace/constants.ts (1)

• PLUGIN_CATEGORY_WITH_COLLECTIONS (25-30)

🔇 Additional comments (2)

web/app/components/plugins/marketplace/index.tsx (1)

12-31: LGTM — simplified tree without altering behavior.
The hydration flow remains intact under HydrateQueryClient, and the UI structure is clearer.

web/app/components/plugins/marketplace/atoms.ts (1)

19-27: Confirm the URL query key for active plugin type.
If the contract still expects category, switching to tab will break back/forward compatibility and URL restoration. If that’s not intentional, keep the key consistent.

🔧 If `category` is still the contract

 export function useActivePluginType() {
-  return useQueryState('tab', marketplaceSearchParamsParsers.category)
+  return useQueryState('category', marketplaceSearchParamsParsers.category)
 }

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}