Update newbs_building_firmware.md #23662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed all of the .c references to .json
jacobjeffery
commented
May 4, 2024
|
|
||
| Open your `keymap.c` file in your text editor. Inside this file you'll find the structure that controls how your keyboard behaves. At the top of `keymap.c` there may be some defines and enums that make the keymap easier to read. Farther down you'll find a line that looks like this: | ||
| Open your `keymap.json` file in your text editor. Inside this file you'll find the structure that controls how your keyboard behaves. At the top of `keymap.c` there may be some defines and enums that make the keymap easier to read. Farther down you'll find a line that looks like this: |
There was a problem hiding this comment.
I missed the second .c reference in this paragraph.
zvecr
requested changes
May 5, 2024
There was a problem hiding this comment.
The majority of keyboards still have the default keymap implemented with keymap.c, which is then used by qmk new-keymap. Also, the text blocks after these changes, still refer to typical keymap.c logic.
The change as it is right now, is more likely to confuse new users.
|
Gotcha,. Thank you @zvecr. Admittedly I'm may have moved a bit too quickly here. |
|
Closing for now as we will rework this area post #23451. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed all of the .c references to .json
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist