-
-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow codegen of keymap.json
=> keymap.c
without requiring layers/layout etc.
#23451
Open
tzarc
wants to merge
6
commits into
qmk:develop
Choose a base branch
from
tzarc:layoutless-keymap-json
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
reviewed
May 9, 2024
zvecr
reviewed
May 9, 2024
This was referenced May 9, 2024
Moved back to draft until I get time to sort out test failures etc. Across the org: https://github.com/search?q=org%3Aqmk+__KEYMAP_GOES_HERE__&type=code |
14 tasks
tzarc
force-pushed
the
layoutless-keymap-json
branch
from
August 12, 2024 12:49
69a2886
to
bdee456
Compare
zvecr
reviewed
Aug 12, 2024
Cleared draft state. Seems like it's now properly working both inside qmk_firmware and inside qmk_userspace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows for
keymap.c
to coexist withkeymap.json
. Anything inkeymap.json
will take precedence and supplying stuff in both will cause failures, but that comes with the territory.Have migrated the onekey console keymap so that there's at least one keymap in-tree.
Minimal
keymap.json
could be something like this:...with a corresponding
keymap.c
as per normal usage patterns.Types of Changes
Checklist